#19190
89%

Ran 03 May 2024 07:50PM UTC

Jobs 1

Files 571

Run time 1min

Badge

Embed ▾

Committed 03 May 2024 07:42PM UTC coverage: 88.287% (-0.02%) from 88.303%

Build # #19190

Build Type

push

github

Committed by

ejona86

Commit Message

xds: Plumb locality in xds_cluster_impl and weighted_target

As part of gRFC A78:

> To support the locality label in the WRR metrics, we will extend the
> `weighted_target` LB policy (see A28) to define a resolver attribute
> that indicates the name of its child. This attribute will be passed
> down to each of its children with the appropriate value, so that any
> LB policy that sits underneath the `weighted_target` policy will be
> able to use it.

xds_cluster_impl is involved because it uses the child names in the
AddressFilter, which must match the names used by weighted_target.
Instead of using Locality.toString() in multiple policies and assuming
the policies agree, we now have xds_cluster_impl decide the locality's
name and pass it down explicitly. This allows us to change the name
format to match gRFC A78:

> If locality information is available, the value of this label will be
> of the form `{region="${REGION}", zone="${ZONE}",
> sub_zone="${SUB_ZONE}"}`, where `${REGION}`, `${ZONE}`, and
> `${SUB_ZONE}` are replaced with the actual values. If no locality
> information is available, the label will be set to the empty string.

Run Details

31507 of 35687 relevant lines covered (88.29%)

0.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	92.09	-0.21%	../netty/src/main/java/io/grpc/netty/NettyServerHandler.java
2	81.05	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
3	88.57	-8.57%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
4	96.26	0.18%	../xds/src/main/java/io/grpc/xds/WeightedTargetLoadBalancer.java
4	88.52	0.0%	../xds/src/main/java/io/grpc/xds/WrrLocalityLoadBalancer.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
9	95.63	0.05%	../xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java
10	93.75	-0.24%	../xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19190.1	03 May 2024 07:50PM UTC	571	88.29

grpc / grpc-java / #19190
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19190

grpc / grpc-java / #19190 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19190

grpc / grpc-java / #19190
89%

README BADGES
x