#18720
89%

Ran 16 Jul 2023 08:11PM UTC

Jobs 1

Files 550

Run time 6s

Badge

Embed ▾

pending completion

Build # #18720

Build Type

push

github-actions

Committed by

web-flow

Commit Message

xds: Encode the service authority in XdsNameResolver (#10207)

Encode the service authority before passing it into gRPC util in the xDS name resolver to handle xDS requests which might contain multiple slashes. Example: xds:///path/to/service:port.

As currently the underlying Java URI library does not break the encoded authority into host/port correctly simplify the check to just look for '@' as we are only interested in checking for user info to validate the authority for HTTP.

This change also leads to few changes in unit tests that relied on this check for invalid authorities which now will be considered valid.

Just like #9376, depending on Guava packages such as URLEscapers or PercentEscapers leads to internal failures(Ex: Unresolvable reference to com.google.common.escape.Escaper from io.grpc.internal.GrpcUtil). To avoid these issues create an in house version that is heavily inspired by grpc-go/grpc.

Run Details

30655 of 34740 relevant lines covered (88.24%)

0.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	90.63	-3.13%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
2	93.27	-0.21%	../core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
2	78.95	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
16	90.88	0.92%	../core/src/main/java/io/grpc/internal/GrpcUtil.java
25	94.92	0.01%	../xds/src/main/java/io/grpc/xds/XdsNameResolver.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#18720.1	16 Jul 2023 08:11PM UTC	550	88.24

grpc / grpc-java / #18720
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #18720

grpc / grpc-java / #18720 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #18720

grpc / grpc-java / #18720
89%

README BADGES
x