grpc / grpc-java
89%

DEFAULT BRANCH: master
Repo Added
Files 653
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 88.836% (+0.008%) from 88.828%
#20272

push

github

web-flow 
core,opentelemetry: Fix server metric labels on early close (#12774)

This addresses the server-side OpenTelemetry metric labeling bug from
#12117 where a generated method can be recorded as `grpc.method="other"`
if `streamClosed()` happens before `serverCallStarted()`.

### What changed

- add an internal `StatsTraceContext.ServerCallMethodListener` hook so
tracers can consume an already-resolved primary-registry
`MethodDescriptor`
- resolve the immutable internal primary registry on the transport path
and seed method classification before the async `MethodLookup` path runs
- keep fallback registry lookup on the existing async path
- update the OpenTelemetry server tracer to use the early-resolved
method classification for close metrics

### Why this shape

- avoids tracer-side `HandlerRegistry` lookup
- uses only the immutable internal primary registry for early
transport-path lookup
- keeps fallback registry lookup on the existing async path

### Tests

- primary generated method: early close preserves the generated method
name
- primary non-generated method: early close still records `other`
- fallback generated method: fallback lookup remains on the existing
async path and does not introduce early transport-path classification
- tracer-level regression: `serverCallMethodResolved()` +
`streamClosed()` records the generated method name without waiting for
`serverCallStarted()`

### Notes

- `ServerCallMethodListener` is an internal hook that carries the
resolved `MethodDescriptor`; tracers consume the resolved result instead
of performing registry lookup themselves
- `ServerImpl` uses `InternalHandlerRegistry` explicitly for the primary
registry to make it clear that the early transport- path lookup is
limited to the immutable internal primary registry
- this PR intentionally does not widen transport-path lookup to the
fallback registry

Ref #12117

36260 of 40817 relevant lines covered (88.84%)

0.89 hits per line

Relevant lines Covered
40817 RELEVANT LINES 36260 COVERED LINES
0.89 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#20272 master core,opentelemetry: Fix server metric labels on early close (#12774) This addresses the server-side OpenTelemetry metric labeling bug from #12117 where a generated method can be recorded as `grpc.method="other"` if `streamClosed()` happens before... push web-flow github
88.84
#20271 master xds: pre-parse custom metric names in WRR load balancer (#12773) Introduce ParsedMetricName in MetricReportUtils to pre-parse configured custom metric names into Enums and key Strings on config initialization in WeightedRoundRobinLoadBalancerConf... push web-flow github
88.83
#20270 master api: Add a parser/editor for URL encoded query params push jdcormie github
88.82
#20269 master okhttp: Optimize HPACK to index :path Allow the :path pseudo-header to be added to the HPACK dynamic table in the gRPC-Java OkHttp transport. In gRPC, the :path header typically represents the service and method name (e.g., /package.Service/Meth... push ejona86 github
88.84
#20268 master compiler: Avoid compile error on weird proto file names This only matters when `@generated=javax` is used, so it shouldn't matter much. It isn't guaranteed that javac will interpret the file as UTF-8, but it is exceedingly common, and it doesn't... push web-flow github
88.82
#20267 master binder: Remove redundant ServerInbound.serverTransport field (#12734) push web-flow github
88.84
#20266 master xds: skip DiscoveryRequest for unsubscribed types on stream ready (#12782) ## TL;DR When the bootstrap declares more than one xDS server (e.g. a default server for LDS/CDS plus an authority-specific EDS-only server), grpc-java was sending CDS/LD... push web-flow github
88.83
#20265 master core: Clarify missing content-type on HTTP error responses (#12720) ## Summary In this case, grpc-java preserves the HTTP status-based context, but may later append `invalid content-type: null`. That seems misleading when the response is missin... push web-flow github
88.84
#20264 master binder: Give clear error when message is larger than parcel Yes, it is lacking a test, but it seems we don't yet have good testing tools to help for tests like this. b/507253841 push ejona86 github
88.81
#20263 master core: Make NameResolverFactoryToProviderFacade transparent w.r.t io.grpc.Uri push jdcormie github
88.82
See All Builds (17291)