grpc / grpc-java
89%

DEFAULT BRANCH: master
Repo Added
Files 630
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 88.694% (+0.005%) from 88.689%
#20197

push

github

web-flow 
xds: reuse GrpcXdsTransport and underlying gRPC channel to the same xDS server by ref-counting

This PR implements reusing the gRPC xDS transport (and underlying gRPC
channel) to the same xDS server by ref-counting, which is already
implemented in gRPC C++
([link](https://github.com/grpc/grpc/blob/5a3a5d531/src/core/xds/grpc/xds_transport_grpc.cc#L399-L414))
and gRPC Go
([link](https://github.com/grpc/grpc-go/blob/81c7924ec/internal/xds/clients/grpctransport/grpc_transport.go#L78-L120)).
This optimization is expected to reduce memory footprint of the xDS
management server and xDS enabled clients as channel establishment and
lifecycle management of the connection is expensive.

* Implemented a map to store `GrpcXdsTransport` instances keyed by the
`Bootstrapper.ServerInfo` and each `GrpcXdsTransport` has a ref count.
Note, the map cannot be simply keyed by the xDS server address as the
client could have different channel credentials to the same xDS server,
which should be counted as different transport instances.
* When `GrpcXdsTransportFactory.create()` is called, the existing
transport is reused if it already exists in the map and increment its
ref count, otherwise create a new transport, store it in the map, and
increment its ref count.
* When `GrpcXdsTransport.shutdown()` is called, its ref count is
decremented and the underlying gRPC channel is shut down when its ref
count reaches zero.
* Note this ref-counting of the `GrpcXdsTransport` is different and
orthogonal to the ref-counting of the xDS client keyed by the xDS server
target name to allow for xDS-based fallback per [gRFC
A71](https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md).

Prod risk level: Low
* Reusing the underlying gRPC channel to the xDS server would not affect
the gRPC xDS (ADS/LRS) streams which would be multiplexed on the same
channel, however, this means new xDS (ADS/LRS) streams and RPCs may fail
due ... (continued)

35473 of 39995 relevant lines covered (88.69%)

0.89 hits per line

Relevant lines Covered
39995 RELEVANT LINES 35473 COVERED LINES
0.89 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#20197 master xds: reuse GrpcXdsTransport and underlying gRPC channel to the same xDS server by ref-counting This PR implements reusing the gRPC xDS transport (and underlying gRPC channel) to the same xDS server by ref-counting, which is already implemented in... push web-flow github
88.69
#20196 master Cleanup old checkForUpdates restrictions (#12687) f36defa2d upgraded error_prone_annotations and 4de471891 bumped minSdkVersion for android-interop-testing. push web-flow github
88.69
#20195 master android-interop-testing: Workaround build mergeExtDexDebug race (#12697) 4de471891 upgraded android-interop-testing to SDK version 23, but this had previously been avoided because it triggered a Gradle or AGP bug. The race happened to not trigger... push web-flow github
88.69
#20194 master android-interop-testing: replace deprecated classes (#12689) push web-flow github
88.7
#20193 master android-interop-testing: replace deprecated classes (#12689) push web-flow github
88.7
#20192 master Remove InternalResolutionResult from DnsNameResolver The internal result was needed before 90d0fabb1 allowed addresses to fail yet still provide attributes and service config. Now the code can just use the regular API. This does cause a behavior... push ejona86 github
88.69
#20191 master core: Enable dns "caching" on Android DnsNameResolver discards refresh requests if it has been too soon after the last refresh, because the result is assumed to be identical to the previous fetch. Android itself will adhere to the RR's TTL, so re... push ejona86 github
88.67
#20190 master android-interop-testing: Remove usage of MultiDexApplication Since we're only supporting API levels 23+, all the supported Android versions handle multidex natively, and without any bugs to workaround. Also bump some minSdkVersion that didn't ge... push web-flow github
88.69
#20189 master core: Wait for backoff timer on address update in pick_first The backoff timer is only used when serializeRetries=true, and that exists to match the old/current pick_first's behavior as closely as possible. InternalSubchannel.updateAddresses() wo... push web-flow github
88.7
#20188 master remove checked-in protoc zip (#12675) push web-flow github
88.69
See All Builds (17216)