#19868
89%

Ran 17 Jun 2025 01:46PM UTC

Jobs 1

Files 615

Run time 17min

Badge

Embed ▾

Committed 17 Jun 2025 01:36PM UTC coverage: 88.559% (-0.01%) from 88.571%

Build # #19868

Build Type

push

github

Committed by

ejona86

Commit Message

xds: XdsNR should be subscribing to clusters with XdsDepManager

This is missing behavior defined in gRFC A74:

> As per gRFC A31, the ConfigSelector gives each RPC a ref to the
> cluster that was selected for it to ensure that the cluster is not
> removed from the xds_cluster_manager LB policy config before the RPC
> is done with its LB picks. These cluster refs will also hold a
> subscription for the cluster from the XdsDependencyManager, so that
> the XdsDependencyManager will not stop watching the cluster resource
> until the cluster is removed from the xds_cluster_manager LB policy
> config.

Without the logic, RPCs can race and see the error:

> INTERNAL: CdsLb for cluster0: Unable to find non-dynamic root cluster

Fixes #12152. This fixes the regression introduced in 297ab05e

Run Details

34552 of 39016 relevant lines covered (88.56%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	87.88	-3.03%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
1	96.12	-0.78%	../util/src/main/java/io/grpc/util/MultiChildLoadBalancer.java
2	92.89	-0.28%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
2	87.5	-1.92%	../xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19868.1	17 Jun 2025 01:46PM UTC	615	88.56

grpc / grpc-java / #19868
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19868

grpc / grpc-java / #19868 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19868

grpc / grpc-java / #19868
89%

README BADGES
x