#19237
89%

Ran 14 May 2024 06:45PM UTC

Jobs 1

Files 578

Run time 1min

Badge

Embed ▾

Committed 14 May 2024 06:37PM UTC coverage: 88.424% (-0.03%) from 88.45%

Build # #19237

Build Type

push

github

Committed by

ejona86

Commit Message

core: Fully delegate picks to DelayedClientTransport

DelayedClientTransport already had to handle all the cases, so
ManagedChannelImpl picking was acting only as an optimization.
Optimizing DelayedClientTransport to avoid the lock when not queuing
makes ManagedChannelImpl picking entirely redundant, and allows us to
remove the duplicate race-handling logic.

This avoids double-picking when queuing, where ManagedChannelImpl does a
pick, decides to queue, and then DelayedClientTransport re-performs the
pick because it doesn't know which pick version was used. This was
noticed with RLS, which mutates state within the picker.

Run Details

32035 of 36229 relevant lines covered (88.42%)

0.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	81.05	0.0%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
3	93.26	-1.69%	../core/src/main/java/io/grpc/internal/AbstractClientStream.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
6	96.1	0.08%	../core/src/main/java/io/grpc/internal/DelayedClientTransport.java
6	88.07	-2.47%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
56	93.76	-0.11%	../core/src/main/java/io/grpc/internal/ManagedChannelImpl.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19237.1	14 May 2024 06:45PM UTC	578	88.42

grpc / grpc-java / #19237
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19237

grpc / grpc-java / #19237 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19237

grpc / grpc-java / #19237
89%

README BADGES
x