#19161
89%

Ran 16 Apr 2024 11:36PM UTC

Jobs 1

Files 564

Run time 1min

Badge

Embed ▾

Committed 16 Apr 2024 11:27PM UTC coverage: 88.117% (-0.01%) from 88.13%

Build # #19161

Build Type

push

github

Committed by

web-flow

Commit Message

netty: Handle write queue promise failures (#11016)

Handles Netty write frame failures caused by issues in the Netty
itself.

Normally we don't need to do anything on frame write failures because
the cause of a failed future would be an IO error that resulted in
the stream closure.  Prior to this PR we treated these issues as a
noop, except the initial headers write on the client side.

However, a case like netty/netty#13805 (a bug in generating next
stream id) resulted in an unclosed stream on our side. This PR adds
write frame future failure handlers that ensures the stream is
cancelled, and the cause is propagated via Status.

Fixes #10849

Run Details

31182 of 35387 relevant lines covered (88.12%)

0.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	93.77	-0.16%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpServerTransport.java
1	97.5	-0.73%	../netty/src/main/java/io/grpc/netty/NettyClientStream.java
2	81.05	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
2	88.07	-0.82%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
3	73.81	-2.38%	../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
19	92.07	0.0%	../netty/src/main/java/io/grpc/netty/NettyServerHandler.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19161.1	16 Apr 2024 11:36PM UTC	564	88.12

grpc / grpc-java / #19161
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19161

grpc / grpc-java / #19161 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19161

grpc / grpc-java / #19161
89%

README BADGES
x