#19416
89%

Ran 12 Aug 2024 06:32PM UTC

Jobs 1

Files 607

Run time 2min

Badge

Embed ▾

Committed 12 Aug 2024 06:23PM UTC coverage: 84.469% (-0.002%) from 84.471%

Build # #19416

Build Type

push

github

Committed by

web-flow

Commit Message

xds: WRRPicker must not access unsynchronized data in ChildLbState

There was no point to using subchannels as keys to
subchannelToReportListenerMap, as the listener is per-child. That meant
the keys would be guaranteed to be known ahead-of-time and the
unsynchronized getOrCreateOrcaListener() during picking was unnecessary.

The picker still stores ChildLbStates to make sure that updating weights
uses the correct children, but the picker itself no longer references
ChildLbStates except in the constructor. That means weight calculation
is moved into the LB policy, as child.getWeight() is unsynchronized, and
the picker no longer needs a reference to helper.

Run Details

33389 of 39528 relevant lines covered (84.47%)

0.84 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	90.69	-0.27%	../core/src/main/java/io/grpc/internal/ClientCallImpl.java
2	78.95	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
2	96.13	-1.1%	../util/src/main/java/io/grpc/util/MultiChildLoadBalancer.java
2	98.38	0.01%	../xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java
3	93.26	-1.69%	../core/src/main/java/io/grpc/internal/AbstractClientStream.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19416.1	12 Aug 2024 06:32PM UTC	607	84.47

grpc / grpc-java / #19416
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19416

grpc / grpc-java / #19416 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19416

grpc / grpc-java / #19416
89%

README BADGES
x