grpc / grpc-java / #19702
89%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 609
Run time 35min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.587% (-0.005%) from 88.592%
#19702

push

github

web-flow 
xds: Change how xDS filters are created by introducing Filter.Provider (#11883)

This is the first step towards supporting filter state retention in
Java. The mechanism will be similar to the one described in [A83]
(https://github.com/grpc/proposal/blob/master/A83-xds-gcp-authn-filter.md#filter-call-credentials-cache)
for C-core, and will serve the same purpose. However, the
implementation details are very different due to the different nature
of xDS HTTP filter support in C-core and Java.

In Java, xDS HTTP filters are backed by classes implementing
`io.grpc.xds.Filter`, from here just called "Filters". To support
Filter state retention (next PR), Java's xDS implementation must be
able to create unique Filter instances per:
- Per HCM
  `envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager`
- Per filter name as specified in
  `envoy.extensions.filters.network.http_connection_manager.v3.HttpFilter.name`

This PR **does not** implements Filter state retention, but lays the
groundwork for it by changing how filters are registered and
instantiated. To achieve this, all existing Filter classes had to be
updated to the new instantiation mechanism described below.

Prior to these this PR, Filters had no livecycle. FilterRegistry
provided singleton instances for a given typeUrl. This PR introduces
a new interface `Filter.Provider`, which instantiates Filter classes.
All functionality that doesn't need an instance of a Filter is moved
to the Filter.Provider. This includes parsing filter config proto
into FilterConfig and determining the filter kind
(client-side, server-side, or both).

This PR is limited to refactoring, and there's no changes to the
existing behavior. Note that all Filter Providers still return
singleton Filter instances. However, with this PR, it is now possible
to create Providers that return a new Filter instance each time
`newInstance` is called.

34252 of 38665 relevant lines covered (88.59%)

0.89 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
47.62
 -4.76% ../core/src/main/java/io/grpc/internal/PickSubchannelArgsImpl.java
1
90.91
 0.91% ../xds/src/main/java/io/grpc/xds/RouterFilter.java
2
93.11
 -0.31% ../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
2
90.0
 2.5% ../xds/src/main/java/io/grpc/xds/Filter.java
3
93.26
 -1.69% ../core/src/main/java/io/grpc/internal/AbstractClientStream.java
3
95.07
 -0.44% ../core/src/main/java/io/grpc/internal/RetriableStream.java
3
0.0
 0.0% ../xds/src/main/java/io/grpc/xds/InternalRbacFilter.java
5
84.89
 0.22% ../xds/src/main/java/io/grpc/xds/XdsListenerResource.java
17
86.23
 -0.43% ../xds/src/main/java/io/grpc/xds/RbacFilter.java
18
71.23
 -0.2% ../xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java
20
93.73
 -0.44% ../xds/src/main/java/io/grpc/xds/XdsServerWrapper.java
21
94.81
 -0.17% ../xds/src/main/java/io/grpc/xds/XdsNameResolver.java
22
89.77
 -0.33% ../xds/src/main/java/io/grpc/xds/FaultFilter.java
Jobs
ID Job ID Ran Files Coverage
1 #19702.1 609
88.59
Source Files on build #19702