#19045
89%

Ran 16 Feb 2024 07:19PM UTC

Jobs 1

Files 553

Run time 34s

Badge

Embed ▾

Committed 16 Feb 2024 07:08PM UTC coverage: 88.316% (-0.02%) from 88.333%

Build # #19045

Build Type

push

github

Committed by

web-flow

Commit Message

netty: improve server handling of writes to reset streams (#10258)

* netty: improve server handling of writes to reset streams

A server stream can be reset by the client while server writes are still queued. After the stream is reset, the netty connection will forget the stream object. The `NettyServerHandler` must deal with that situation. `sendResponseHandlers` already had some code to do that. This change standardizes that code and adds it to `sendGrpcFrame`. This fixes a potential bug where a `SendGrpcFrameCommand` with `endOfStream=true` would raise an `AssertionError` if written to a reset stream. (This bug is not currently reachable because `endOfStream=false` for all server `SendGrpcFrameCommand` objects.)

* Do not call into the encoder when we know the stream is gone.

Run Details

31133 of 35252 relevant lines covered (88.32%)

0.88 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19045.1	16 Feb 2024 07:19PM UTC	553	88.32

grpc / grpc-java / #19045
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #19045

grpc / grpc-java / #19045 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #19045

grpc / grpc-java / #19045
89%

README BADGES
x