#19899
89%

Ran 06 Jul 2025 08:06PM UTC

Jobs 1

Files 615

Run time 1min

Badge

Embed ▾

Committed 03 Jul 2025 06:14AM UTC coverage: 88.52% (-0.02%) from 88.541%

Build # #19899

Build Type

push

github

Committed by

web-flow

Commit Message

core: grpc-timeout should always be positive (#12201)

PROTOCOL-HTTP2.md specifies "TimeoutValue → {positive integer as ASCII
string of at most 8 digits}". Zero is not positive, so it should be
avoided. So make sure timeouts are at least 1 nanosecond instead of 0
nanoseconds.

grpc-go recently began disallowing zero timeouts in
https://github.com/grpc/grpc-go/pull/8290 which caused a regression as
grpc-java can generate such timeouts. Apparently no gRPC implementation
had previously been checking for zero timeouts.

Instead of changing the max(0) to max(1) everywhere, just move the max
handling into TimeoutMarshaller, since every caller of TIMEOUT_KEY was
doing the same max() handling.

Before fd8fd517d (in 2016!), grpc-java actually behaved correctly, as it
failed RPCs with timeouts "<= 0". The commit changed the handling to the
max(0) handling we see now.

b/427338711

Run Details

34643 of 39136 relevant lines covered (88.52%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	93.17	-0.14%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
2	81.05	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
3	95.07	-0.44%	../core/src/main/java/io/grpc/internal/RetriableStream.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
10	93.22	-1.72%	../core/src/main/java/io/grpc/internal/AbstractClientStream.java
10	92.91	0.31%	../core/src/main/java/io/grpc/internal/GrpcUtil.java
29	86.49	-0.03%	../inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19899.1	06 Jul 2025 08:06PM UTC	615	88.52

grpc / grpc-java / #19899
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19899

grpc / grpc-java / #19899 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19899

grpc / grpc-java / #19899
89%

README BADGES
x