grpc / grpc-java / #19625
89%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 607
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.546% (+0.002%) from 88.544%
#19625

push

github

ejona86 
netty: Fix getAttributes() data races in NettyClientTransportTest

Since approximately the LBv2 API (the current API) was introduced, gRPC
won't use a transport until it is ready. Long ago, transports could be
used before they were ready and these old tests were not waiting for the
negotiator to complete before starting. We need them to wait for the
handshake to complete to avoid a test-only data race in getAttributes()
noticed by TSAN.

Throwing away data frames in the Noop handshaker is necessary to act
like a normal handshaker; they don't allow data frames to pass until the
handshake is complete. Without the handling, it goes through invalid
code paths in NettyClientHandler where a terminated transport becomes
ready, and a similar data race.

```
  Write of size 4 at 0x00008db31e2c by thread T37:
    #0 io.grpc.netty.NettyClientHandler.handleProtocolNegotiationCompleted(Lio/grpc/Attributes;Lio/grpc/InternalChannelz$Security;)V NettyClientHandler.java:517
    #1 io.grpc.netty.ProtocolNegotiators$GrpcNegotiationHandler.userEventTriggered(Lio/netty/channel/ChannelHandlerContext;Ljava/lang/Object;)V ProtocolNegotiators.java:937
    #2 io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(Ljava/lang/Object;)V AbstractChannelHandlerContext.java:398
    #3 io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(Lio/netty/channel/AbstractChannelHandlerContext;Ljava/lang/Object;)V AbstractChannelHandlerContext.java:376
    #4 io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(Ljava/lang/Object;)Lio/netty/channel/ChannelHandlerContext; AbstractChannelHandlerContext.java:368
    #5 io.grpc.netty.ProtocolNegotiators$ProtocolNegotiationHandler.fireProtocolNegotiationEvent(Lio/netty/channel/ChannelHandlerContext;)V ProtocolNegotiators.java:1107
    #6 io.grpc.netty.ProtocolNegotiators$WaitUntilActiveHandler.channelActive(Lio/netty/channel/ChannelHandlerContext;)V ProtocolNegotiators.java:1011
    ...

  Previo... (continued)

33676 of 38032 relevant lines covered (88.55%)

0.89 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
91.37
 -0.21% ../netty/src/main/java/io/grpc/netty/NettyServerHandler.java
1
47.62
 -4.76% ../core/src/main/java/io/grpc/internal/PickSubchannelArgsImpl.java
1
96.55
 -1.72% ../xds/src/main/java/io/grpc/xds/internal/security/certprovider/CertificateProvider.java
1
75.4
 -0.79% ../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
2
91.43
 -5.71% ../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
Jobs
ID Job ID Ran Files Coverage
1 #19625.1 607
88.55
Source Files on build #19625