#19093
89%

Ran 08 Mar 2024 05:55PM UTC

Jobs 1

Files 556

Run time 6min

Badge

Embed ▾

Committed 08 Mar 2024 05:47PM UTC coverage: 88.296% (-0.002%) from 88.298%

Build # #19093

Build Type

push

github

Committed by

web-flow

Commit Message

rls: Fix a local and remote race

The local race passes `rlsPicker` to the channel before
CachingRlsLbClient is finished constructing. `RlsPicker` can use
multiple of the fields not yet initialized. This seems not to be
happening in practice, because it appears like it would break things
very loudly (e.g., NPE).

The remote race seems incredibly hard to hit, because it requires an RPC
to complete before the pending data tracking the RPC is added to a map.
But with if a system is at 100% CPU utilization, maybe it can be hit. If
it is hit, all RPCs needing the impacted cache entry will forever be
buffered.

Run Details

31149 of 35278 relevant lines covered (88.3%)

0.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	96.03	-0.66%	../core/src/main/java/io/grpc/internal/DelayedClientTransport.java
2	91.43	-5.71%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
3	79.37	-2.38%	../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
39	81.74	0.04%	../rls/src/main/java/io/grpc/rls/CachingRlsLbClient.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19093.1	08 Mar 2024 05:55PM UTC	556	88.3

grpc / grpc-java / #19093
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19093

grpc / grpc-java / #19093 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19093

grpc / grpc-java / #19093
89%

README BADGES
x