#19678
89%

Ran 05 Feb 2025 06:48PM UTC

Jobs 1

Files 607

Run time 2min

Badge

Embed ▾

Committed 05 Feb 2025 06:37PM UTC coverage: 88.566% (-0.03%) from 88.592%

Build # #19678

Build Type

push

github

Committed by

web-flow

Commit Message

xds: Improve XdsNR's selectConfig() variable handling

The variables from the do-while are no longer initialized to let the
compiler verify that the loop sets each. Unnecessary comparisons to null
are also removed and is more obvious as the variables are never set to
null. Added a minor optimization of computing the RPCs path once instead
of once for each route. The variable declarations were also sorted to
match their initialization order.

This does fix an unlikely bug where if the old code could successfully
matched a route but fail to retain the cluster, then when trying a
second time if the route was _not_ matched it would re-use the prior route
and thus infinite-loop failing to retain that same cluster.

It also adds a missing cast to unsigned long for a uint32 weight. The old
code would detect if the _sum_ was negative, but a weight using 32 bits
would have been negative and never selected.

Run Details

33755 of 38113 relevant lines covered (88.57%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	47.62	-4.76%	../core/src/main/java/io/grpc/internal/PickSubchannelArgsImpl.java
1	96.55	-1.72%	../xds/src/main/java/io/grpc/xds/internal/security/certprovider/CertificateProvider.java
2	93.47	-0.33%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpServerTransport.java
2	81.05	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
2	81.67	-1.67%	../servlet/src/main/java/io/grpc/servlet/ServletAdapter.java
3	92.38	-1.43%	../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java
3	73.81	-2.38%	../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
7	88.56	0.1%	../xds/src/main/java/io/grpc/xds/XdsRouteConfigureResource.java
17	94.98	-0.22%	../xds/src/main/java/io/grpc/xds/XdsNameResolver.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19678.1	05 Feb 2025 06:48PM UTC	607	88.57

grpc / grpc-java / #19678
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19678

grpc / grpc-java / #19678 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19678

grpc / grpc-java / #19678
89%

README BADGES
x