grpc / grpc-java / #19596
89%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 601
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.598% (-0.009%) from 88.607%
#19596

push

github

web-flow 
Re-enable animalsniffer, fixing violations

In 61f19d707a I swapped the signatures to use the version catalog. But I
failed to preserve the `@signature` extension and it all seemed to
work... But in fact all the animalsniffer tasks were completing as
SKIPPED as they lacked signatures. The build.gradle changes in this
commit are to fix that while still using version catalog.

But while it was broken violations crept in. Most violations weren't
too important and we're not surprised went unnoticed. For example, Netty
with TLS has long required the Java 8 API
`setEndpointIdentificationAlgorithm()`, so using `Optional` in the same
code path didn't harm anything in particular. I still swapped it to
Guava's `Optional` to avoid overuse of `@IgnoreJRERequirement`.

One important violation has not been fixed and instead I've disabled the
android signature in api/build.gradle for the moment.  The violation is
in StatusException using the `fillInStackTrace` overload of Exception.
This problem [had been noticed][PR11066], but we couldn't figure out
what was going on. AnimalSniffer is now noticing this and agreeing with
the internal linter. There is still a question of why our interop tests
failed to notice this, but given they are no longer running on pre-API
level 24, that may forever be a mystery.

[PR11066]: https://github.com/grpc/grpc-java/pull/11066

33481 of 37790 relevant lines covered (88.6%)

0.89 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
93.47
 -0.33% ../okhttp/src/main/java/io/grpc/okhttp/OkHttpServerTransport.java
3
96.94
 0.02% ../util/src/main/java/io/grpc/util/OutlierDetectionLoadBalancer.java
3
96.83
 0.0% ../core/src/main/java/io/grpc/internal/SpiffeUtil.java
3
91.94
 -1.42% ../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java
6
69.57
 0.0% ../stub/src/main/java/io/grpc/stub/AbstractStub.java
27
90.53
 0.0% ../netty/src/main/java/io/grpc/netty/ProtocolNegotiators.java
Jobs
ID Job ID Ran Files Coverage
1 #19596.1 601
88.6
Source Files on build #19596