#19814
89%

Ran 21 May 2025 05:30PM UTC

Jobs 1

Files 615

Run time 1min

Badge

Embed ▾

Committed 21 May 2025 05:19PM UTC coverage: 88.618% (+0.008%) from 88.61%

Build # #19814

Build Type

push

github

Committed by

web-flow

Commit Message

compiler: Default to @generated=omit (#12080)

After many years of issue 9179 being open, there's been nothing to show
that we need the javax.annotations.Generated annotation. Most tools use
file paths and a few check for annotations with "Generated" in the name.
ErrorProne has a few that check for javax.annotations.Generated, but
only UnnecessarilyFullyQualified looks like it'd be a problem and it is
disabled by default. We're not getting any more information, no users
have reported issues with `@generated=omit`, and the existing dependency
is annoying users, so just drop it.

Given we will still retain the GrpcGenerated annotation, it seems highly
likely things are already okay. Even if there are problems they would
probably be addressed by adding a io.grpc.stub.annotations.Generated
annotation or small tweaks. In the short-term, (non-Bazel) users can use
`@generated=javax`, but long-term we could consider removing the option
assuming we've resolved any outstanding issues.

We will want to update the examples and the README to remove the
org.apache.tomcat:annotations-api dependency after the next release.

Fixes #9179

Run Details

34787 of 39255 relevant lines covered (88.62%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	88.89	-0.41%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
1	96.55	-0.57%	../core/src/main/java/io/grpc/internal/DelayedClientTransport.java
1	87.88	-3.03%	../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
1	77.08	-1.04%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
1	95.92	0.09%	../xds/src/main/java/io/grpc/xds/internal/security/certprovider/FileWatcherCertificateProviderProvider.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19814.1	21 May 2025 05:30PM UTC	615	88.62

grpc / grpc-java / #19814
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19814

grpc / grpc-java / #19814 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19814

grpc / grpc-java / #19814
89%

README BADGES
x