#19701
89%

Ran 18 Feb 2025 03:48PM UTC

Jobs 1

Files 609

Run time 1min

Badge

Embed ▾

Committed 18 Feb 2025 03:33PM UTC coverage: 88.592% (-0.001%) from 88.593%

Build # #19701

Build Type

push

github

Committed by

ejona86

Commit Message

util: Use acceptResolvedAddresses() for MultiChildLb children

A failing Status from acceptResolvedAddresses means something is wrong
with the config, but parts of the config may still have been applied.
Thus there are now two possible flows: errors that should prevent
updateOverallBalancingState() and errors that should have no effect
other than the return code. To manage that, MultChildLb must always be
responsible for calling updateOverallBalancingState().
acceptResolvedAddressesInternal() was inlined to make that error
processing easier. No existing usages actually needed to have logic
between updating the children and regenerating the picker.

RingHashLb already was verifying that the address list was not empty, so
the short-circuiting when acceptResolvedAddressesInternal() returned an
error was impossible to trigger. WrrLb's updateWeightTask() calls the
last picker, so it can run before acceptResolvedAddressesInternal(); the
only part that matters is re-creating the weightUpdateTimer.

Run Details

34238 of 38647 relevant lines covered (88.59%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	93.43	0.16%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
1	77.08	-1.04%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
5	96.12	-0.96%	../util/src/main/java/io/grpc/util/MultiChildLoadBalancer.java
5	98.37	0.29%	../xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java
16	91.87	0.2%	../xds/src/main/java/io/grpc/xds/RingHashLoadBalancer.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19701.1	18 Feb 2025 03:48PM UTC	609	88.59

grpc / grpc-java / #19701
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19701

grpc / grpc-java / #19701 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19701

grpc / grpc-java / #19701
89%

README BADGES
x