safe-global / safe-modules / 9869500757

97%

master: 85%

push

github

Emit Event on Shared Signer Configuration (#456)

Fixes
https://github.com/hats-finance/Safe-0x2909fdefd/issues/3

This PR adds an event that is emitted on shared signer configuration.
Note that the event is emitted in the context of the configured Safe
account. In order to prevent event `topic0` collisions, we chose an
explicitly verbose name.

With respect to indexing, we explicitly chose **not** to index any of
the fields so that it matches the `Created` event:


https://github.com/safe-global/safe-modules/blob/bb5e1f736/modules/passkey/contracts/interfaces/ISafeSignerFactory.sol#L13-L20

To re-iterate on the reasons we chose to not index some of the fields
(same reasoning applies to `Created` event above):
- `x` and `y`: These are single-use public key coordinates attached to a
passkey. It doesn't make sense to filter events by "all events with `x`
value", or similarly "all events with `y` value". Furthermore, you can
compute the `signer` (which is indexed in the `Created` event) from the
key coordinates, so you can to some degree search for signers for a
given key coordinate.
- `verifiers`: This felt more like a configuration than something that
Dapps would need to filter by. Why it might be interesting to see on
chain which verifiers are being used, tools like Dune can help with
this, and the additional cost of an indexed field is not worth it in our
opinion.

28 of 28 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

91 of 91 relevant lines covered (100.0%)

30.01 hits per line