safe-global / safe-modules / 8922186849

100%

master: 85%

push

github

Emit signer created event (#402)

Fixes #397

Changes in PR:
- [x] Emit signer created event in factory
- [x] Document
- [x] Test

The signer address is not indexed based on the justification below:

Using `indexed` keyword allows searching for events by filter (useful
when searching events using libraries like web3.py, web3.js, etc.),
Also, having indexed param would mean that `etherum.logs` table in Dune
would have signer address available in `topic1` column. If not marked as
indexed, then singer address need to be decoded from `data` column.

https://docs.soliditylang.org/en/latest/contracts.html#events

Indexing is accompanied by additional gas cost. So, indexed is
recommended only if necessary. As we use dune and parsing data column of
`etherum.logs` would give signer address, I don't think indexing is
needed.

34 of 50 branches covered (68.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

122 of 129 relevant lines covered (94.57%)

18.47 hits per line