safe-global / safe-modules / 8375038467

100%

master: 85%

push

github

Correct EIP-7212 Behaviour (#334)

Fixes #309 

This PR fixes an issue where the FCL P-256 verifier behaviour was not
following the precompile. In particular, I used the Polygon team
implementation:


https://github.com/maticnetwork/bor/blob/43958943e/core/vm/contracts.go#L1209-L1231

To validated expectations, I ran the following script against a Polygon
Mumbai execution node to inspect the precompile return values:

<details><summary><code>test-rip-7212.sh</code></summary>

```sh
echo "just right"
curl -s -X POST "$NODE_URL" -H 'Content-Type: application/json' --data '@-' <<JSON | jq -r .result
{
  "jsonrpc": "2.0",
  "id": 42,
  "method": "eth_call",
  "params": [
    {
      "to": "0x<a class=hub.com/safe-global/safe-modules/commit/0000000000000000000000000000000000000100">000000000<a href="https://github.com/safe-global/safe-modules/commit/1768f9d4856afb04f5ea6bb577ed0955473916a3">",
      "data": "0x<a class="double-link" href="https://github.com/safe-global/safe-modules/commit/bb5a52f42f9c9261ed4361f59422a1e30036e7c3">bb5a52f42</a><a class="double-link" href="https://github.com/safe-global/safe-modules/commit/2b270c8807a419feca6050232ba3a8be6b94d5ec">2b270c880</a><a class="double-link" href="https://github.com/safe-global/safe-modules/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/safe-global/safe-modules/commit/80a6d9d1190a436effe50d85a1eee859b8cc6af9">80a6d9d11</a><a class="double-link" href="https://github.com/safe-global/safe-modules/commit/&lt;a class=&quot;double-link&quot; href="https://git"><a class=hub.com/safe-global/safe-modules/commit/bd5c2e184cd60b855d442f5b3c7b11eb6c4e0ae7">bd5c2e184<a class=hub.com/safe-global/safe-modules/commit/525fe710fab9aa7c77a67f79e6fadd762927b105">525fe710f<a class=hub.com/safe-global/safe-modules/commit/12bae3eddcfe467828128bad2903269919f70860">12bae3edd<a class=hub.com/safe-global/safe-modules/commit/69c8c4df6c732838c7787964eaac00e5921fb149">69c8c4df6<a class=hub.com/safe-global/safe-modules/commit/8a60f4606766b3d9685001558d1a974e7341513e">8a60f4606"
    },
    "latest"
  ]
}
JSON

echo "mismatch"
curl -s -X POST "$NODE_URL" -H 'Content-Type: application/json' --data '@-' <<JSON | jq -r .result
{
  "jsonrpc": "2.0",
  "id": 42,
  "method": "eth_call",
  "params": [
    {
      "to": "0x0000000000000000000000000000000000000100",
      "data": "0x<a class="double-link" href="https://github.com/safe-global/safe-modules/commit/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee">eeeeeeeee</a><a class="double-link" href="https://github.com/safe-global/safe-modules/commit/eeeeeeeeeeeeeeeeeeeeeeee2ba3a8be6b94d5ec">eeeeeeeee</a>80a6d9d1190a436effe50d85a1eee859b8cc6af9bd5c2e184cd60b855d442f5b3c7b11eb6c4e0ae7525fe710fab9aa7c77a67f79e6fadd762927b10512bae3eddcfe467828128bad2903269919f7086069c8c4df6c732838c7787964eaac00e5921fb1498a60f4606766b3d9685001558d1a974e7341513e"
    },
    "latest"
  ]
}
JSON

echo "too short"
curl -s -X POST "$NODE_URL" -H 'Content-Type: application/json' --data '@-' <

24 of 44 branches covered (54.55%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

93 of 102 relevant lines covered (91.18%)

3.95 hits per line