safe-global / safe-modules / 8799961809

100%

master: 85%

push

github

Create SafeWebAuthnSignerProxy (#370)

Fixes #312 

Changes in PR:
- [x] Create `SafeWebAuthnSignerSingleton`. This contract has no
storage, no immutables, and no constants.
- [x] Create `SafeWebAuthnSignerProxy` and corresponding proxy factory
i.e. `SafeWebAuthnSignerProxyFactory`

- Create immutable `singleton` contract when deploying proxy factory
- `SafeWebAuthnSignerProxyFactory.isValidSignatureForSigner(...)`
forwards to singleton contract instead directly calling `WebAuthn`
library
- `SafeWebAuthnSignerProxy` uses no storage to avoid 4337 storage access
restriction violation.
- Add unit test to verify that `SafeWebAuthnSignerProxy` forwards every
call to singleton address
- [x] Report gas usage metrics
- [x] Update github workflow to execute benchmarking tests separately.
(This is required to get accurate gas usage numbers)
- [x] Update documentation
- [x] Replace `SafeWebAuthnSigner` with `SafeWebAuthnSignerProxy`, same
for factory contract
- [x] Update all tests to use `SafeWebAuthnSignerProxy`. Hence, the
large diff in this PR.


Benchmark number from this PR:

```
Gas Benchmarking Proxy [@bench]
    SafeWebAuthnSignerProxy
      ⛽ deployment: 164012
      ✔ Benchmark signer deployment cost (10[38](https://github.com/safe-global/safe-modules/actions/runs/8739938588/job/23982409583?pr=370#step:4:39)ms)
      ⛽ verification (FreshCryptoLib): 216248
      ✔ Benchmark signer verification cost with FreshCryptoLib verifier (201ms)
      ⛽ verification (daimo-eth): 346151
      ✔ Benchmark signer verification cost with daimo-eth verifier (186ms)
      ⛽ verification (Dummy): 14[40](https://github.com/safe-global/safe-modules/actions/runs/8739938588/job/23982409583?pr=370#step:4:41)2
      ✔ Benchmark signer verification cost with Dummy verifier
```

Benchmark number from main:
```
  Gas Benchmarking [@bench]
    SafeWebAuthnSigner
      ⛽ deployment: 491288
      ✔ Benchmark signer deployment cost (654m... (continued)

34 of 50 branches covered (68.0%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 3 files covered. (100.0%)

121 of 128 relevant lines covered (94.53%)

18.22 hits per line