safe-global / safe-modules / 9858401950

100%

master: 85%

push

github

Add a `sherif` monorepo linter to the CI (#452)

The PR introduces the 'sherif' linter, which is an opinionated,
zero-config linter designed specifically for JavaScript monorepos. This
addition aims to improve code quality and standardize development
practices across the safe-modules project.

**CI Integration:**
The PR adds 'sherif' to the CI workflow. This ensures that the linter
runs automatically on pull requests, helping to catch potential issues
early in the development process.
**Linter Features:**

'Sherif' offers several features:
- Zero-configuration setup, making it easy to integrate and use
- Fast performance, as it doesn't require node_modules to be installed
- Compatibility with various package managers (PNPM, NPM, Yarn)
- Ability to prevent regressions by enforcing consistent dependency
versions across the monorepo

**Found and fixed issues:**
```
2 issues found in ./package.json:

 ⨯ error The root package.json should be private to prevent accidentaly publishing it to a registry. root-package-private-field
  │ {
  +   "private": "true"   ← missing private field.
  │ }

 ⨯ error The root package.json should specify the package manager and version to use. Useful for tools like corepack. root-package-manager-field
  │ {
  +   "packageManager": "..."   ← missing packageManager field.
  │ }

1 issue found in ./packages/4337-provider/package.json:

 ⨯ error Private packages shouldn't have @types/* in dependencies. types-in-dependencies
  │ {
  │   "private": "true",     ← package is private...
  │   ...
  -   "dependencies": {      ← but has @types/* in dependencies...
  -      "@types/node": "...",
  -   },
  │   ...
  +   "devDependencies": {   ← instead of devDependencies.
  +      "@types/node": "...",
  +   }
  │ }

13 issues found in ./:

 ⨯ error Dependency @account-abstraction/contracts has multiple versions defined in the workspace. multiple-dependency-versions
  ./examples
      43... (continued)

28 of 28 branches covered (100.0%)

Branch coverage included in aggregate %.

90 of 90 relevant lines covered (100.0%)

30.06 hits per line