safe-global / safe-modules / 9031211580

100%

master: 85%

push

github

Optimize WebAuthn Signer Proxy Implementation (#406)

This PR uses assembly to encode the calldata for calling the WebAuthn
signer singleton instead of using native Solidity. This has notable
improvements to the deployment gas costs:

**Before**:

```
    SafeWebAuthnSignerProxy
      ⛽ deployment: 107899
      ✔ Benchmark signer deployment cost (867ms)
```

**After**:

```
    SafeWebAuthnSignerProxy
      ⛽ deployment: 92481
      ✔ Benchmark signer deployment cost (849ms)
```

This is a result of reduced codesize and not significantly more
performant code.

---

I also cleaned up some comments in this PR.

34 of 48 branches covered (70.83%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

122 of 129 relevant lines covered (94.57%)

18.77 hits per line