safe-global / safe-modules / 8920852675

100%

master: 85%

push

github

Fix Precompile Address Width (#396)

When looking through the code, I realized that I made a mistake in #379.
Specifically, we specify that precompiles fit into a `uint32`, when in
fact they fit into a `uint16`:

https://eips.ethereum.org/EIPS/eip-1352

This PR changes the code to encode the `P256.Verifiers` type to be a
`uint16 || address` instead of a slightly larger `uint32`.

Alternatively, we _could_ use a full 96 bits to represent the precompile
address and make `P256.Verifiers` a `uint256` (this has a small positive
effect on gas usage and code size, as it gets rid of compiler generated
masking code).

34 of 50 branches covered (68.0%)

Branch coverage included in aggregate %.

121 of 128 relevant lines covered (94.53%)

18.19 hits per line