safe-global / safe-modules / 9031345321

100%

master: 85%

push

github

Rework Safe Signer Launchpad (#377)

This PR does a rework of some of the implementation details of the
`SafeSignerLaunchpad` contract in light of some observations from the
previous PR #376.

Namely, this changes the initialization process to work in a slightly
different way:
1. Set the target singleton to a special slot when the entry point
executes the `initCode` for the account. Safe `setup` also happens at
this point, meaning that any `DELEGATECALL` to the Safe singleton should
work and be valid.
2. Signature verification checks that the account is an owner. This has
the side-effect that you can initialize an account with multiple custom
ECDSA owners and use any of them to sign the first user operation.
3. Promote the Safe to the singleton that was previously in storage.

The main difference with the previous flow is that we no longer have two
separate `setup` initializers that we `DELEGATECALL` to. Additionally,
we added checks that prevent double initialization as well as reentrency
issues in the execution function.

In addition, this also opens up a pretty clear path for supporting
multiple owners with the launchpad as the account has already undergone
"regular" Safe setup. This is relevant for #372.

Unit tests in order to reach 100% coverage will be introduced in a
follow up.

36 of 50 branches covered (72.0%)

Branch coverage included in aggregate %.

29 of 40 new or added lines in 1 file covered. (72.5%)

121 of 132 relevant lines covered (91.67%)

18.41 hits per line