safe-global / safe-modules / 9677603386

100%

master: 85%

push

github

Add a new logUserOperationGas function and improve user operation gas estimation (#446)

This PR fixes https://github.com/safe-global/safe-modules/issues/425 by
introducing a new `estimateUserOperationGas` function, which runs the
simulation using AA's reference `EntryPointSimulations` contract to
ensure we use correct estimations for our test user operations.
Previously, we set them to arbitrarily high numbers to make the tests
pass. I also improved a couple of tests where we set `maxFeePerGas` to 0
by actually obtaining the prefund value the account paid for the
operation.

The code was mostly borrowed from the account-abstraction reference
bundler and is not suitable for use in a production environment.

It also includes the `logUserOperationGas` function, which fixes the
core issue of displaying the actual gas used by the user operation.

Example log:
```
  Gas Metering
    Safe Deployment + Enabling 4337 Module
           Used 418349 gas (Account or Paymaster) for >Safe with 4337 Module Deployment<
           Used 415210 gas (Transaction) for >Safe with 4337 Module Deployment<
      ✔ Safe with 4337 Module Deployment (137ms)
    Safe Deployment + Enabling 4337 Module + Native Transfers
           Used 449725 gas (Account or Paymaster) for >Safe with 4337 Module Deployment + Native Transfer<
           Used 447665 gas (Transaction) for >Safe with 4337 Module Deployment + Native Transfer<
      ✔ Safe with 4337 Module Deployment + Native Transfer
           Used 191691 gas (Account or Paymaster) for >Safe with 4337 Module Native Transfer<
           Used 182078 gas (Transaction) for >Safe with 4337 Module Native Transfer<
      ✔ Safe with 4337 Module Native Transfer
    Safe Deployment + Enabling 4337 Module + Token Operations
           Used 435081 gas (Account or Paymaster) for >Safe with 4337 Module Deployment + ERC20 Transfer<
           Used 426148 gas (Transaction) for >Safe with 4337 Module Deployment + ERC20 ... (continued)

20 of 20 branches covered (100.0%)

Branch coverage included in aggregate %.

39 of 39 relevant lines covered (100.0%)

36.62 hits per line