safe-global / safe-modules / 9990468990

100%

master: 85%

push

github

Signature Length Check FV (#464)

Closes #461 

This PR adds a rule which verifies that the signature length check is
ensured using the `_checkSignaturesLength(...)` in the `Safe4337Module`.

The rule ensures that a signature that the bundler could manipulate,
which could clear the check in Safe using `checkSignatures(...)` will
still get caught using the `_checkSignaturesLength(...)`. For this, we
use a `canonicalSignatureHash(...)` which generates the same hash for
valid signatures, with and without the excess data. An example is added
to show this case before the function is written.

Also have added the workflow for checking the same in CI (Currently, it
uses a script, which will be modified in a later PR to be consistent
with our other repos).

24 of 24 branches covered (100.0%)

Branch coverage included in aggregate %.

51 of 51 relevant lines covered (100.0%)

42.96 hits per line