safe-global / safe-modules / 9857842200

100%

master: 85%

push

github

Improve Proxy Behaviour With the IR Optimizer (#451)

This PR marks regions of assembly that previously weren't as memory safe
- this allows the IR optimizer to do a few extra optimizations and
improve overall gas consumption for the contracts.

**Before**
```
  Gas Benchmarking [@bench]
    SafeWebAuthnSignerProxy
      ⛽ deployment: 91107
      ✔ Benchmark signer deployment cost (517ms)
      ⛽ verification (Dummy): 12564
      ✔ Benchmark signer verification cost with Dummy verifier (108ms)
      ⛽ verification (Precompile): 13379
      ✔ Benchmark signer verification cost with Precompile verifier (109ms)
```

**After**
```
  Gas Benchmarking [@bench]
    SafeWebAuthnSignerProxy
      ⛽ deployment: 89900
      ✔ Benchmark signer deployment cost (518ms)
      ⛽ verification (Dummy): 12553
      ✔ Benchmark signer verification cost with Dummy verifier (110ms)
      ⛽ verification (Precompile): 13368
      ✔ Benchmark signer verification cost with Precompile verifier (113ms)
```

Note that writing to `ptr` instead of `0` and changing the position of
the `revert` and `return` actually helps the compiler produce more
optimal code :shrug:. Solidity optimizer is really a black box to me
sometimes :sweat_smile:.

<details><summary>Additionally, marking the proxy implementation as
"memory safe" has a net negative effect on the optimizer, so we
<bold>intentionally</bold> don't mark it as such (even if the changes
make it memory safe)</summary>

```
  Gas Benchmarking [@bench]
    SafeWebAuthnSignerProxy
      ⛽ deployment: 90100
      ✔ Benchmark signer deployment cost (529ms)
      ⛽ verification (Dummy): 12570
      ✔ Benchmark signer verification cost with Dummy verifier (113ms)
      ⛽ verification (Precompile): 13385
      ✔ Benchmark signer verification cost with Precompile verifier (113ms)
```

</details>

~~This PR is a **DRAFT** - as it would change the code in a meaningful
way that would require u... (continued)

28 of 28 branches covered (100.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

90 of 90 relevant lines covered (100.0%)

30.06 hits per line