safe-global / safe-modules / 8557004048

100%

master: 85%

push

github

Base-64 Encode Challenge Directly Into JSON String (#358)

This PR encodes the 32 byte challenge directly into the client data JSON
that needs to be computed for the signing message. This allows the code
to avoid copy loops when computing the client data JSON that would be
required pre-`mcopy` opcode if the challenge were encoded to a separate
base-64 string.

This change has some nice small improvements to the overall cost of the
verifying signatures, and more substantial improvements to the
deployment cost of the signer.

<details><summary>Before:</summary>

```
  Gas Benchmarking [@bench]
    WebAuthnSigner
      ⛽ deployment: 533256
      ✔ Benchmark signer deployment cost (835ms)
      ⛽ verification (Dummy): 12278
      ✔ Benchmark signer verification cost with Dummy verifier
```

</details>

<details><summary>After:</summary>

```
  Gas Benchmarking [@bench]
    WebAuthnSigner
      ⛽ deployment: 515421
      ✔ Benchmark signer deployment cost (765ms)
      ⛽ verification (Dummy): 12106
      ✔ Benchmark signer verification cost with Dummy verifier
```

</details>

25 of 44 branches covered (56.82%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

94 of 102 relevant lines covered (92.16%)

5.88 hits per line