kaidokert / rm32

63%

main: 63%

LAST BUILD ON BRANCH pr24_1

branch: pr24_1

CHANGE BRANCH

x

Reset

Sync Branches

• pr24_1
• main
• pr1
• pr10_1
• pr11_1
• pr12_1
• pr13_1
• pr14_1
• pr15_1
• pr16_1
• pr17_1
• pr18_1
• pr19_1
• pr20_1
• pr21_1
• pr22_1
• pr23_1
• pr25_1
• pr26_1
• pr27_1
• pr28_1
• pr29_1
• pr2_1
• pr2_2
• pr2_3
• pr2_4
• pr2_5
• pr2_6
• pr2_7
• pr2_ref
• pr30_1
• pr31_1
• pr32_1
• pr33_1
• pr34_1
• pr3_1
• pr5_1
• pr7_1
• pr8_1
• pr_codecov1
• pr_codecov2
• system-tick
• tmps

Build # 25205956364

Build Type

Pull #30

github

Committed by kaidokert

Commit Message

Fix wait_time u16 truncation and reset_for_step missing zc_found clear

Two wait_time bugs: record_zero_cross and update_timing_from_timer
truncated new_ci to u16 BEFORE dividing by 2. At low RPM (new_ci >
65535), this produces completely wrong wait_time. C code divides
the u32 value first, then truncates on assignment to u16.

reset_for_step was missing zc_found = false. C code clears zcfound
together with bemfcounter after every commutation step. Without this,
zero_cross_detected() stays false after the first detection in the
startup path, stalling old_routine startup.

Pull Request Pull Request #30: BemfState encapsulation, PWM compare methods, ramp bug fix

Coverage Stats

128 of 142 new or added lines in 3 files covered. (90.14%)

1 existing line in 1 file now uncovered.

3541 of 5651 relevant lines covered (62.66%)

779.09 hits per line