kaidokert / rm32 / 25205956364

63%

main: 63%

Build Type

Pull #30

github

Committed by kaidokert

Commit Message

Fix wait_time u16 truncation and reset_for_step missing zc_found clear

Two wait_time bugs: record_zero_cross and update_timing_from_timer
truncated new_ci to u16 BEFORE dividing by 2. At low RPM (new_ci >
65535), this produces completely wrong wait_time. C code divides
the u32 value first, then truncates on assignment to u16.

reset_for_step was missing zc_found = false. C code clears zcfound
together with bemfcounter after every commutation step. Without this,
zero_cross_detected() stays false after the first detection in the
startup path, stalling old_routine startup.

Pull Request Pull Request #30: BemfState encapsulation, PWM compare methods, ramp bug fix

Coverage Stats

128 of 142 new or added lines in 3 files covered. (90.14%)

1 existing line in 1 file now uncovered.

3541 of 5651 relevant lines covered (62.66%)

779.09 hits per line