MushroomObserver / mushroom-observer
98%
main: 98%

Repo Added 21 Oct 2014 06:32PM UTC

Committed 10 Jun 2026 11:05AM UTC coverage: 97.586% (+0.007%) from 97.579%

Committed by

Commit Message

Close remaining coverage gaps on #4489

- `Mappable::ClusteredCollection`: drop the `else ""` fallbacks in
  `cluster_url_for`, `mapset_title_for`, and the final `""` in
  `cluster_label_for`. `MapSet#init_objects_and_derive_extents`
  raises on non-mappable objects, so by the time these methods
  run every obj responds to `observation?` (true for ::Observation
  / MinimalObservation, false for everything else). The two-branch
  shape is exhaustive. Same for `display_name` — Mappable objects
  always expose it; only `text_name` is observation-only.
- Delete the `controller_model_name` overrides in
  `Observations::MapsController` and `Locations::MapsController`.
  Both controllers run custom index/show actions that don't go
  through `ApplicationController::Indexes`'s standard flow; nothing
  in the request path calls `controller_model_name` on either.
  The overrides were defensive but dead.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

323 of 323 new or added lines in 14 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

45608 of 46736 relevant lines covered (97.59%)

753.85 hits per line

46736 RELEVANT LINES 45608 COVERED LINES

753.85 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
27271862767	nimmo-map-component-makeover	Close remaining coverage gaps on #4489 - `Mappable::ClusteredCollection`: drop the `else ""` fallbacks in `cluster_url_for`, `mapset_title_for`, and the final `""` in `cluster_label_for`. `MapSet#init_objects_and_derive_extents` raises on n...	Pull #4489	10 Jun 2026 11:09AM UTC	nimmolo	github	97.59
27270764961	nimmo-map-component-makeover	Close coverage gaps on #4489's touched files After #4489's last commit, coveralls reported per-file gaps on the non-ApplicationController touched files. Closes the ones that are fixable; the rest are dead defensive branches that MapSet's `init_ob...	Pull #4489	10 Jun 2026 10:47AM UTC	nimmolo	github	97.58
27270030369	nimmo-map-component-makeover	Address Copilot review #4 on #4489: private method + Hash q_param stub - `Observations::MapsController#maps_index_phlex_view` was a public controller method. Rails treats public instance methods on a controller as candidate actions; even with...	Pull #4489	10 Jun 2026 10:32AM UTC	nimmolo	github	97.56
27228906253	nimmo-map-component-makeover	Address Copilot review #3 on #4489 Four stale-documentation nits and one test-flake fix Copilot caught: - `Components::Map` docstring claimed Popup was a `module` `include`d into the host class; it's actually a standalone Phlex view rendered ...	Pull #4489	09 Jun 2026 07:04PM UTC	nimmolo	github	97.56
27228906094	nimmo-map-component-makeover	Merge 6ed2b6ed8 into b8a72dd84	Pull #4489	09 Jun 2026 07:03PM UTC	web-flow	github	pending completion
27228595467	nimmo-map-component-makeover	Replace "chrome-y" with "view-layer" per user style Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	Pull #4489	09 Jun 2026 06:58PM UTC	nimmolo	github	97.56
27228064796	nimmo-map-component-makeover	Components::Map / Popup: switch from `query_param: Hash` to `query: Query` Uses the new `current_query` value helper (from #4488) so callers pass a typed `Query` object and the component derives the URL `q=` hash internally. The Hash form was "wh...	Pull #4489	09 Jun 2026 06:48PM UTC	nimmolo	github	97.55
27226349338	nimmo-map-component-makeover	Address Copilot review on #4489 + delete dead helper tests Three things: - `Components::Map#effective_query_param` was calling `controller.q_param`, but `controller` is also a String prop on this class (the Stimulus controller name, default ...	Pull #4489	09 Jun 2026 06:17PM UTC	nimmolo	github	97.55

MushroomObserver / mushroom-observer
98%
main: 98%

MushroomObserver / mushroom-observer 98% main: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on nimmo-map-component-makeover

Recent builds

MushroomObserver / mushroom-observer
98%
main: 98%

README BADGES
x

CHANGE BRANCH
x