MushroomObserver / mushroom-observer / 27271862767

98%

main: 98%

Build Type

Pull #4489

github

Committed by nimmolo

Commit Message

Close remaining coverage gaps on #4489

- `Mappable::ClusteredCollection`: drop the `else ""` fallbacks in
  `cluster_url_for`, `mapset_title_for`, and the final `""` in
  `cluster_label_for`. `MapSet#init_objects_and_derive_extents`
  raises on non-mappable objects, so by the time these methods
  run every obj responds to `observation?` (true for ::Observation
  / MinimalObservation, false for everything else). The two-branch
  shape is exhaustive. Same for `display_name` — Mappable objects
  always expose it; only `text_name` is observation-only.
- Delete the `controller_model_name` overrides in
  `Observations::MapsController` and `Locations::MapsController`.
  Both controllers run custom index/show actions that don't go
  through `ApplicationController::Indexes`'s standard flow; nothing
  in the request path calls `controller_model_name` on either.
  The overrides were defensive but dead.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4489: Components::Map: consolidate make_map + helpers into one component

Coverage Stats

323 of 323 new or added lines in 14 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

45608 of 46736 relevant lines covered (97.59%)

753.85 hits per line