MushroomObserver / mushroom-observer / 27226349338

98%

main: 98%

Build Type

Pull #4489

github

Committed by nimmolo

Commit Message

Address Copilot review on #4489 + delete dead helper tests

Three things:

- `Components::Map#effective_query_param` was calling
  `controller.q_param`, but `controller` is also a String prop on
  this class (the Stimulus controller name, default "map"). Phlex
  prop readers shadow value-helper methods, so the call would
  resolve to `"map".q_param` and raise. Switch to the
  registered `q_param` helper directly (no receiver).
- `Mappable::ClusteredCollection#mapset_title_for` returned an
  empty string for observations with lat/lng but no location.
  The deleted `MapHelper#map_location_strings` fell back to
  formatted coordinates for that case, so this was a regression
  (blank marker tooltips for GPS-only observations). Restore the
  coords fallback as `observation_title_for(obs)` plus the
  `format_{lat,lng}` helpers.
- Delete `test/helpers/map_helper_test.rb` and
  `test/helpers/map_popup_helper_test.rb` — both test methods on
  the deleted helper modules. The same paths are covered by
  `test/components/map_test.rb` and the maps_controller tests.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4489: Components::Map: consolidate make_map + helpers into one component

Coverage Stats

316 of 327 new or added lines in 14 files covered. (96.64%)

2 existing lines in 1 file now uncovered.

45486 of 46628 relevant lines covered (97.55%)

754.46 hits per line