MushroomObserver / mushroom-observer
95%
main: 95%

LAST BUILD BRANCH: jdc-new-limit-total-search-string-length
DEFAULT BRANCH: main
Repo Added
Files 822
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH jdc-new-limit-total-search-string-length
branch: jdc-new-limit-total-search-string-length
CHANGE BRANCH
x

coverage: 95.271% (-0.008%) from 95.279%
20197216627

Pull #3587

github

JoeCohen 
Fix RuboCop offenses in SearchController#pattern

- Extract pattern_too_long? method to reduce ABC size
- Use redirect_back_or_to instead of redirect_back
- Wrap long line in flash_error call
Pull Request #3587: Limit total search string length

8 of 11 new or added lines in 3 files covered. (72.73%)

31269 of 32821 relevant lines covered (95.27%)

701.66 hits per line

Relevant lines Covered
32821 RELEVANT LINES 31269 COVERED LINES
701.66 HITS PER LINE
Source Files on jdc-new-limit-total-search-string-length

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
20197216627 jdc-new-limit-total-search-string-length Fix RuboCop offenses in SearchController#pattern - Extract pattern_too_long? method to reduce ABC size - Use redirect_back_or_to instead of redirect_back - Wrap long line in flash_error call Pull #3587 JoeCohen github
95.27
20197216968 jdc-new-limit-total-search-string-length Merge c643d9a06 into 263cd6458 Pull #3587 web-flow github pending completion  
20196890757 jdc-new-limit-total-search-string-length Add server-side validation for PatternSearch length Prevent Puma errors when PatternSearch pattern exceeds 9500 characters. Validates pattern length in SearchController#pattern action and redirects with error message if too long. - Add length ch... Pull #3587 JoeCohen github
95.27
20195878334 jdc-new-limit-total-search-string-length Exclude bounding box coordinates from search length validation Geographic coordinate fields (North, South, East, West in_box fields) are now excluded from the 9500 character limit. These numeric inputs are bounded and don't contribute meaningfull... Pull #3587 JoeCohen github
95.28
20195878685 jdc-new-limit-total-search-string-length Merge 8df452f98 into 263cd6458 Pull #3587 web-flow github pending completion  
20195776117 jdc-new-limit-total-search-string-length Exclude rank fields from search length validation count Rank dropdown selections (rank and rank_range) in Names search are now excluded from the 9500 character limit. These short enum values don't contribute meaningfully to URL length but were co... Pull #3587 JoeCohen github
95.28
20195140593 jdc-new-limit-total-search-string-length Fix search type mismatch in length validator flash div lookup Stimulus converts underscores to hyphens in data attribute values, so searchTypeValue is "species-lists" but the flash div ID is "search_species_lists_flash". This caused the validator... Pull #3587 JoeCohen github
95.28
20194931707 jdc-new-limit-total-search-string-length Exclude "no" and "yes" from search length validation count The misspellings dropdown default value "no" was being counted toward the 9500 character limit, causing the validator to report 9503 instead of 9501 when user entered exactly 9501 charact... Pull #3587 JoeCohen github
95.28
20194093735 jdc-new-limit-total-search-string-length Fix search input length validation to exclude defaults and metadata The search length validator was counting form metadata (CSRF tokens, method fields) and default values (true/false, 0.0) toward the 9500 character limit, causing incorrect length... Pull #3587 JoeCohen github
95.28
20185648132 jdc-new-limit-total-search-string-length Removed server-side validation methods - Removes these unused methods from searchable.rb since all validation now happens client-side via the Stimulus controller. - Resolves the RuboCop warning about the predicate method naming convention. Pull #3587 JoeCohen github
95.28
See All Builds (17588)