MushroomObserver / mushroom-observer / 27228906253

98%

main: 98%

Build Type

Pull #4489

github

Committed by nimmolo

Commit Message

Address Copilot review #3 on #4489

Four stale-documentation nits and one test-flake fix Copilot caught:

- `Components::Map` docstring claimed Popup was a `module` `include`d
  into the host class; it's actually a standalone Phlex view rendered
  via `render(Popup.new(set:, query:))` from `Clustering#decorate_mapset`.
  Rewritten to describe the actual three-piece structure (two
  mixins + one standalone view), including the second entry point
  through `Observations::MapsController#popup`.
- `@example` for clustered usage still showed `query_param:
  q_param(@query)`; switched to `query: @query` to match the
  current API.
- `register_element :center` was on `Components::Map` but the
  `<center>` markup lives in `Components::Map::Popup` now (which
  already registers it). Deleted the orphaned registration.
- `MAX_GROUP_NAMES = 3` same story — only used by the popup, which
  defines its own. Deleted.
- `test/components/map_test.rb#build_min_obs` was assigning
  `id: rand(1_000_000)`. Cluster collections key MapSets by
  `singleton_key_for(obj)` which embeds the id, so a collision
  silently overwrites the prior entry — a flake that's hard to
  reproduce. Switched to a deterministic `next_min_obs_id`
  counter.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4489: Components::Map: consolidate make_map + helpers into one component

Coverage Stats

319 of 330 new or added lines in 14 files covered. (96.67%)

2 existing lines in 1 file now uncovered.

45606 of 46748 relevant lines covered (97.56%)

754.88 hits per line