MushroomObserver / mushroom-observer / 27270764961

98%

main: 98%

Build Type

Pull #4489

github

Committed by nimmolo

Commit Message

Close coverage gaps on #4489's touched files

After #4489's last commit, coveralls reported per-file gaps on the
non-ApplicationController touched files. Closes the ones that are
fixable; the rest are dead defensive branches that MapSet's
`init_objects_and_derive_extents` makes unreachable (it raises on
objects that are neither `observation?` nor `location?`, so the
`else` fallbacks in `cluster_url_for` / `mapset_title_for` /
`cluster_label_for`'s final `""` can never fire).

Code:

- Delete `Components::Map#query_path_params` — dead method (only
  caller is `Components::Map::Popup` which defines its own).
  Closes `app/components/map.rb:278`.
- Drop the empty-array default on `Components::Map`'s `:objects`
  prop and on `Views::Controllers::Observations::Maps::Index`'s
  `:observations` prop. Every caller passes the value explicitly;
  the defaults were never reachable. Closes `app/components/map.rb:75`
  and `app/views/controllers/observations/maps/index.rb:13`.

Tests:

- `test/classes/mappable/clustered_collection_test.rb` (new) —
  3 tests, 12 assertions, exercise the location-shaped object
  branches in `mapset_title_for`, `cluster_url_for`, and
  `cluster_label_for` that the observation-shaped tests in
  `map_test.rb` don't reach.
- `map_test.rb#test_single_observation_popup_label_falls_back_to_id`
  pins the `render_observation_label` id-fallback branch (#4131).
  Closes `app/components/map/popup.rb:215`.

Remaining gaps (1 line each, accepted):

- `app/controllers/{observations,locations}/maps_controller.rb`
  `controller_model_name` overrides — defensive (the default
  derived `Map` would be wrong if the standard index flow ever
  invoked them).
- The 8 unreachable defensive branches in
  `Mappable::ClusteredCollection` described above.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4489: Components::Map: consolidate make_map + helpers into one component

Coverage Stats

325 of 328 new or added lines in 14 files covered. (99.09%)

2 existing lines in 1 file now uncovered.

45612 of 46745 relevant lines covered (97.58%)

757.62 hits per line