MushroomObserver / mushroom-observer
98%
main: 98%

LAST BUILD BRANCH: nimmo-phlex-locations
DEFAULT BRANCH: main
Repo Added
Files 1632
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH nimmo-phlex-locations
branch: SELECT
CHANGE BRANCH
x

coverage: 97.71% (-0.07%) from 97.777%
27617798818

Pull #4547

github

nimmolo 
fixups: address Copilot review on #4547 + add three controller tests

Three real findings from Copilot:

- `locations/search#show` (turbo_stream branch) was using
  `turbo_stream.update(:search_bar_help, html: render_to_string(...))`.
  The `html:` kwarg isn't accepted by Turbo's update builder, so the
  stream would emit an empty template. Match the existing
  `names/search#show` pattern: pass the Phlex view directly as the
  second positional arg.
- `support/donors` Phlex view declared `prop :donor_list,
  _Array(_Hash(String, String))`, but `Donation.donor_list` returns
  hashes with numeric / Time values (`total`, `most_recent`). The
  view only ever reads `donor["who"]`, so the prop is now
  `prop :donor_names, _Array(String)` and the controller maps the
  hash list down to the name array before constructing the view.
- `info/translators_note` was calling `Language.all.sort_by(&:order)`
  inside the Phlex view — an AR query in view code, blocked by
  `no_queries_in_phlex_views_test`. Moved to the controller; the view
  takes a typed `languages:` prop.

Coverage cleanup:

- Deleted two unreachable Phlex views (`info/letter_to_community.rb`,
  `info/risd_terminology.rb`). The ERBs they were converted from had
  no controller action or route; the rendering paths never existed.
- Added smoke tests for `info#translators_note` and
  `locations/help#show` — both were silently 0/total on coveralls.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #4547: controllers: ERB→Phlex sweep for licenses, publications, interests, support, theme, policy, info, locations

1099 of 1123 new or added lines in 64 files covered. (97.86%)

33 existing lines in 5 files now uncovered.

49029 of 50178 relevant lines covered (97.71%)

675.15 hits per line

Relevant lines Covered
50178 RELEVANT LINES 49029 COVERED LINES
675.15 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
27617798818 nimmo-phlex-locations fixups: address Copilot review on #4547 + add three controller tests Three real findings from Copilot: - `locations/search#show` (turbo_stream branch) was using `turbo_stream.update(:search_bar_help, html: render_to_string(...))`. The `html:... Pull #4547 nimmolo github
97.71
27616137055 njw-inat-writeback-env-toggle Make rubocop pre-commit hook honor .rubocop.yml excludes The hook passed staged file paths to `rubocop` without --force-exclusion, so naming a file on the command line overrode AllCops/Exclude. A staged generated file the project already excludes... Pull #4545 mo-nathan github
97.78
27615743826 njw-inat-writeback-env-toggle Replace iNat write-back env toggle with an admin checkbox Supersede the process-wide INAT_SKIP_WRITEBACK env var with a per-import, admin-only control. The importer still defaults to skipping the write-back in development and performing it in pro... Pull #4545 mo-nathan github
97.78
27615744462 njw-inat-writeback-env-toggle Merge 8fff9d2b4 into 756637b59 Pull #4545 web-flow github pending completion  
27614511778 nimmo-phlex-locations tracker_row: drop empty line after class body opener Cosmetic rubocop fix landed while removing the now-redundant NumberWithPrecision include in the previous commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Pull #4547 nimmolo github
97.11
27614423117 nimmo-phlex-locations controllers: ERB→Phlex sweep for licenses, publications, interests, support, theme, policy, info, locations Converts ~38 ERB action templates / partials across eight controller areas to Phlex view classes under `app/views/controllers/`. Each cont... push nimmolo github
97.11
27602117171 nimmo-4535-location-find-on-map add local smoke test for each Google Maps API surface Stand-alone system test that visits the location form and exercises each Google Maps service MO depends on (Maps JavaScript API, Geocoding API, Elevation API). On failure each assertion names ... Pull #4546 nimmolo github
97.78
27601707192 nimmo-4535-location-find-on-map expand to all Google Maps API failure surfaces Generalize `showGeocodeError` → `showGoogleMapsError(label, error)` and route every silent catch through it: - Maps JS API loader catch (was `console.error`) - `window.gm_authFailure` — Google's glo... Pull #4546 nimmolo github
97.78
27601500101 nimmo-4535-location-find-on-map Merge 8b206181e into 756637b59 Pull #4546 web-flow github
97.78
27601470154 nimmo-4535-location-find-on-map location form: surface Google Maps geocode failures (#4535) Issue #4535: clicking "Find on Map" on the location edit page appears to do absolutely nothing. Root cause is in the Google Cloud Console, not the codebase — the Geocoding API is disable... Pull #4546 nimmolo github
97.78
See All Builds (20387)