MushroomObserver / mushroom-observer
96%
main: 96%

Repo Added 21 Oct 2014 06:32PM UTC

Committed 16 May 2026 10:07AM UTC coverage: 96.453%. First build

Committed by

Commit Message

Inline FormNotes help in body; drop heading collapse trigger

Reversed the heading-collapse-trigger approach. Per visual review:
having the help icon in the panel heading was confusing — you
could expand the help block while the panel itself was still
collapsed, so you'd see help text floating above nothing.

New layout (always-visible, no collapse for help):

  - Panel heading: just "Notes" + the panel's own caret. No help
    icon, no `info-collapse-trigger`.
  - Panel body (collapsible by the caret only):
    1. `above_help` prose (single-part mode only)
    2. The textareas (one per part)
    3. Textile-formatting help (always, both modes)

Single-part mode: the prose "what to put in notes" copy lives
above the textarea (where it's the natural reading order), and
the textile-formatting help is below it (where it's reference,
not instruction).

Multi-part mode: just textareas + textile help. No above-help —
users with custom notes parts know what each part is for.

API changes:
- Rename `help_content:` → `above_help:`. The prop is now scoped
  to the single-part above-the-textarea slot (multi-part ignores
  it). FormNotes hardcodes the textile help.
- Revert the `Panel#heading_extras` slot added two commits back —
  no longer needed once the in-heading collapse is gone.

`ObservationForm::NotesPanel#observation_notes_help` →
`observation_above_notes_help`: now returns just the prose Proc
(textile help moved to FormNotes).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

57 of 57 new or added lines in 4 files covered. (100.0%)

38371 of 39782 relevant lines covered (96.45%)

659.05 hits per line

39782 RELEVANT LINES 38371 COVERED LINES

659.05 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
25959255609	nimmo-extract-notes-fields-component	Inline FormNotes help in body; drop heading collapse trigger Reversed the heading-collapse-trigger approach. Per visual review: having the help icon in the panel heading was confusing — you could expand the help block while the panel itself was s...	Pull #4269	16 May 2026 10:12AM UTC	nimmolo	github	96.45
25932012444	nimmo-extract-notes-fields-component	Always render FormNotes help trigger in panel heading Single-part mode was previously rendering its help via the lone textarea's `with_help` slot, which placed the `?` trigger on its own line next to the (now sr-only) field label — no visible con...	Pull #4269	15 May 2026 05:37PM UTC	nimmolo	github	96.45
25928899200	nimmo-extract-notes-fields-component	Add label_sr_only: option; use in FormNotes single-part mode Visual review of the observation notes panel flagged a second redundancy: in single-part mode (when the user has no custom notes parts), the textarea's "Notes:" label was duplicated by ...	Pull #4269	15 May 2026 04:28PM UTC	nimmolo	github	96.45
25928527606	nimmo-extract-notes-fields-component	Move FormNotes help-collapse trigger into the panel heading Visual review flagged a redundancy in the observation notes panel: the Bootstrap Panel heading already says "Notes", but the panel body opened with a `<p><strong>Notes:</strong> <help-tr...	Pull #4269	15 May 2026 04:21PM UTC	nimmolo	github	96.45
25927778268	nimmo-extract-notes-fields-component	Extract Components::FormNotes (Panel + notes textareas) `Components::ObservationFormNotes` was a Phlex re-implementation of the inner half of `shared/_notes_fields.html.erb` (used by the field-slip ERB form). The inner content was nearly identica...	Pull #4269	15 May 2026 04:04PM UTC	nimmolo	github	96.45

MushroomObserver / mushroom-observer
96%
main: 96%

MushroomObserver / mushroom-observer 96% main: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on nimmo-extract-notes-fields-component

Recent builds

MushroomObserver / mushroom-observer
96%
main: 96%

README BADGES
x

CHANGE BRANCH
x