MushroomObserver / mushroom-observer / 27270030369

98%

main: 98%

Build Type

Pull #4489

github

Committed by nimmolo

Commit Message

Address Copilot review #4 on #4489: private method + Hash q_param stub

- `Observations::MapsController#maps_index_phlex_view` was a public
  controller method. Rails treats public instance methods on a
  controller as candidate actions; even with no route, this risks
  someone wiring one up by mistake AND interferes with action-method
  detection. Move it below `private`. Same file's `show` /
  `popup` / `index` remain the public actions.
- `test/components/map_test.rb`'s `find_or_create_query` stub was
  returning `"Q"` (a String) for `q_param`. `Query#q_param` /
  `ApplicationController#q_param` always return a Hash; a String
  routes `add_q_param` through its legacy `?q=ABC`-format-string
  branch instead of the modern `q[key]=value` shape, masking
  URL-shape regressions. Switch the stub to a real Hash.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4489: Components::Map: consolidate make_map + helpers into one component

Coverage Stats

320 of 331 new or added lines in 14 files covered. (96.68%)

2 existing lines in 1 file now uncovered.

45607 of 46749 relevant lines covered (97.56%)

753.69 hits per line