MushroomObserver / mushroom-observer
98%
main: 98%

LAST BUILD BRANCH: 3745-import-from-user-supplied-url
DEFAULT BRANCH: main
Repo Added
Files 1530
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH nimmo-check-index-sorting-controller-method
branch: nimmo-check-index-sorting-controller-method
CHANGE BRANCH
x

coverage: 97.559% (+0.04%) from 97.516%
27115988207

Pull #4477

github

nimmolo 
Query: validate `order_by` against model's available scopes

Closes the silent-fallback hole noted in
[[project-query-order-by-validation]]. Before this commit,
`Query` accepted any string for `order_by` and the dispatcher
in `AbstractModel::OrderingScopes#order_by` silently fell back
to `id: :desc` whenever the supplied key had no matching
`order_by_<key>` private scope on the model. A typo in a
controller's `index_sort_options` rendered a sort dropdown
whose options secretly did nothing — looked plausible, failed
silently, escaped CI.

Adds `Query::Modules::Validation#validate_order_by!` which
runs from `clean_and_validate_params` (the existing
`before_validation` hook). Mirrors the dispatcher's special
cases exactly:
  - blank / nil → skip (Query::Foo.default_order takes over)
  - "none" → skip (dispatcher returns `all` unconditionally)
  - "reverse_X" or "X" → require `Model.order_by_X` (private)

Unknown keys land in `@validation_errors`, propagate to
`query.errors[:base]` via `Query::Validator`, and bubble up
through `lookup_and_save` as save failures (or surface
through `query.valid?` for callers that check).

Test-side: `GeneralExtensions#assert_each_sort_key_resolves`
now drives the same validator (calls `Query.lookup` per key,
checks `query.errors[:base]`) instead of duplicating the
model-private-method introspection. Single source of truth.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #4477: Index sort options: hoist to controllers; delete 13 helpers

60 of 61 new or added lines in 20 files covered. (98.36%)

45040 of 46167 relevant lines covered (97.56%)

755.74 hits per line

Relevant lines Covered
46167 RELEVANT LINES 45040 COVERED LINES
755.74 HITS PER LINE
Source Files on nimmo-check-index-sorting-controller-method

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
27115988207 nimmo-check-index-sorting-controller-method Query: validate `order_by` against model's available scopes Closes the silent-fallback hole noted in [[project-query-order-by-validation]]. Before this commit, `Query` accepted any string for `order_by` and the dispatcher in `AbstractModel::Order... Pull #4477 nimmolo github
97.56
27115039512 nimmo-check-index-sorting-controller-method Coverage chase on #4477: cover branches I touched, delete dead method Branches added or covered: - new test/controllers/application_controller_test.rb with 9 tests covering `change_theme_to` (3 branches), `fix_bad_domains` GET-on-bad-host red... Pull #4477 nimmolo github
97.56
27113419519 nimmo-check-index-sorting-controller-method Merge 7319709d1 into dce6cd033 Pull #4477 web-flow github
97.52
27113242579 nimmo-check-index-sorting-controller-method check_index_sorting: hoist sort tables to controllers, delete 13 helpers Refactors the test-infra contract for index-page sort coverage: each index controller now exposes a public `index_sort_options` instance method returning the `[[key, label],... push nimmolo github
97.52
See All Builds (20206)