MushroomObserver / mushroom-observer
97%
main: 99%

Repo Added 21 Oct 2014 06:32PM UTC

Committed 30 May 2026 09:34PM UTC coverage: 96.513% (+0.02%) from 96.49%

Committed by

Commit Message

visual_groups + visual_models: convert the rest of the folder to Phlex; extend Table#column with arbitrary HTML attrs

Expands #4398's scope per review feedback. The original PR converted only `visual_groups/edit.html.erb` and bridged the rest via `view_context.render(partial: …)`. This commit finishes the conversion across both folders — visual_models is admin-only and parallels the visual_groups shape, so doing both at once keeps the bridge code from lingering.

**New Phlex action views:**
- `Views::Controllers::VisualGroups::Show`
- `Views::Controllers::VisualGroups::Index` (delegates to the shared visual-group table)
- `Views::Controllers::VisualGroups::New`
- `Views::Controllers::VisualModels::Index` (uses `Components::Table`)
- `Views::Controllers::VisualModels::Show` (delegates to the shared table)
- `Views::Controllers::VisualModels::New`
- `Views::Controllers::VisualModels::Edit`

**New shared Phlex views:**
- `Views::Controllers::VisualGroups::ImageMatrix` — image-matrix grid for both edit + show; renders one `StatusLinks` per image.
- `Views::Controllers::VisualGroups::StatusLinks` — per-image status-buttons block (needs-review / include / exclude trio + image-id link). Rendered both inside the matrix grid AND as the body of the `visual_groups/images#update` turbo-stream replace response, so the same Phlex unit drives both the initial render and the post-click swap.
- `Views::Controllers::VisualModels::VisualGroupTable` — the visual-groups-of-a-model table, rendered by `VisualModels::Show` and `VisualGroups::Index`. Uses `Components::Table` for the table-shell + per-column wiring (removes the hand-rolled `<thead>` / `<tbody>` markup).

**Components::Table extension:** `Table#column` now accepts arbitrary HTML attrs (`width: "33%"`, `data: { ... }`, etc.) in addition to the existing `class:`, and forwards them to both the `<th>` and `<td>` for that column. Lets the `VisualModels::Index` table preserve its `width="33%"` cell sizing without go... (continued)

Coverage Stats

290 of 290 new or added lines in 15 files covered. (100.0%)

40050 of 41497 relevant lines covered (96.51%)

667.38 hits per line

41497 RELEVANT LINES 40050 COVERED LINES

667.38 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
26695508853	nimmo-visual-groups-edit-phlex	visual_groups + visual_models: convert the rest of the folder to Phlex; extend Table#column with arbitrary HTML attrs Expands #4398's scope per review feedback. The original PR converted only `visual_groups/edit.html.erb` and bridged the rest via...	Pull #4398	30 May 2026 09:38PM UTC	nimmolo	github	96.51
26682893981	nimmo-visual-groups-edit-phlex	visual_groups: convert edit.html.erb to Views::Controllers::VisualGroups::Edit Replaces the 94-line `app/views/controllers/visual_groups/edit.html.erb` with a Phlex action view at `app/views/controllers/visual_groups/edit.rb`. The form on the pag...	Pull #4398	30 May 2026 11:45AM UTC	nimmolo	github	96.5

MushroomObserver / mushroom-observer
97%
main: 99%

MushroomObserver / mushroom-observer 97% main: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on nimmo-visual-groups-edit-phlex

Recent builds

MushroomObserver / mushroom-observer
97%
main: 99%

README BADGES
x

CHANGE BRANCH
x