MushroomObserver / mushroom-observer
96%
main: 96%

Repo Added 21 Oct 2014 06:32PM UTC

Committed 30 May 2026 11:40AM UTC coverage: 96.497% (+0.007%) from 96.49%

Committed by

Commit Message

visual_groups: convert edit.html.erb to Views::Controllers::VisualGroups::Edit

Replaces the 94-line `app/views/controllers/visual_groups/edit.html.erb` with a Phlex action view at `app/views/controllers/visual_groups/edit.rb`. The form on the page is already Phlex (`VisualGroups::Form` landed earlier); this PR converts the surrounding page chrome — top/bottom nav links, distinct-names list, status-button + text-input filter form, status-count line — and wires the controller to `render(...)` the new class explicitly.

The image-matrix grid (`_image_matrix.html.erb`) stays ERB for now and is bridged in via `view_context.render(partial: …)` to keep this PR's scope to the action template. The partial renders all-Phlex inner components plus the `visual_group_status_links` ERB helper, so an inline conversion would broaden the diff materially; better as a follow-up.

Two small intentional drops:

- **`<p id="notice"><%= notice %></p>`** at the top of the container — a rails-scaffold-generated remnant. The application layout's global flash banner already surfaces `flash[:notice]` for every controller, so this paragraph was a near-empty no-op on every page load. No tests pinned `#notice`. The same pattern still lives in `visual_groups/show.html.erb` and `visual_models/index.html.erb`; those go away with their respective conversions.

The reload-this-page button on the `needs_review` view still goes through `link_to "javascript:window.location.reload(true)"` — Phlex's native `a` strips `javascript:` hrefs as a safety measure, but the registered Rails `link_to` helper keeps them. A self-link to the same URL would let Turbo Drive serve its cached snapshot, defeating the purpose: the needs_review view exists to surface fresh inference data, and `reload(true)` is the only path that guarantees a cache-bypassed full GET.

18 existing controller + Capybara tests pass on the new view; 0 rubocop offenses on the two touched files.

Coverage Stats

76 of 76 new or added lines in 2 files covered. (100.0%)

39855 of 41302 relevant lines covered (96.5%)

673.96 hits per line

41302 RELEVANT LINES 39855 COVERED LINES

673.96 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
26682893981	nimmo-visual-groups-edit-phlex	visual_groups: convert edit.html.erb to Views::Controllers::VisualGroups::Edit Replaces the 94-line `app/views/controllers/visual_groups/edit.html.erb` with a Phlex action view at `app/views/controllers/visual_groups/edit.rb`. The form on the pag...	Pull #4398	30 May 2026 11:45AM UTC	nimmolo	github	96.5

MushroomObserver / mushroom-observer
96%
main: 96%

MushroomObserver / mushroom-observer 96% main: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on nimmo-visual-groups-edit-phlex

Recent builds

MushroomObserver / mushroom-observer
96%
main: 96%

README BADGES
x

CHANGE BRANCH
x