MushroomObserver / mushroom-observer / 27228064796

98%

main: 98%

Build Type

Pull #4489

github

Committed by nimmolo

Commit Message

Components::Map / Popup: switch from `query_param: Hash` to `query: Query`

Uses the new `current_query` value helper (from #4488) so callers
pass a typed `Query` object and the component derives the URL
`q=` hash internally. The Hash form was "whatever the URL gave
us" — a URL-tampering attempt could fill it with garbage. The
`Query` form has already passed `query_from_q_param`'s validated
deserialization.

- `Components::Map` prop is now `prop :query, _Nilable(::Query),
  default: nil`. `effective_query` falls back to `current_query`
  when the prop is nil; `effective_query_param` is just
  `effective_query&.q_param`.
- `Components::Map::Popup` mirrors the prop change. Internal
  `query_path_params` derives the `q:` hash from
  `effective_query&.q_param`.
- `Components::Map::Clustering#decorate_mapset` passes
  `query: effective_query` down to the Popup instead of
  `query_param: effective_query_param`.
- `Observations::MapsController#popup` constructs the Popup with
  `query: current_query` instead of parsing `params[:q]` into a
  raw Hash. `current_query` itself routes through
  `query_from_q_param`, so a malformed URL gets nil instead of
  garbage.

Carries duplicate `current_query` registration into
`Components::Base` + `ApplicationController::Queries` —
identical to #4488, conflict-on-merge is trivial.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4489: Components::Map: consolidate make_map + helpers into one component

Coverage Stats

321 of 332 new or added lines in 14 files covered. (96.69%)

2 existing lines in 1 file now uncovered.

45491 of 46633 relevant lines covered (97.55%)

755.83 hits per line