MushroomObserver / mushroom-observer / 41234144122

99%

main: 99%

Pull #5583

github

Consolidate observation list-management pages, fix padding and sort bugs

Replace div(class: "p-3") with Components::ContentPadded across the
observation project/species-list/field-slip edit pages, and remove a
double-padding bug on the field-slip page (content_padding default
already supplied it).

Extract Components::ObservationListManager to share the two-section
"belongs to / doesn't contain" ListGroup layout between
Observations::Projects::Edit and Observations::SpeciesLists::Edit,
with row content supplied by a caller block.

Give the Projects edit page a sorter (Query::Projects-backed, mirroring
the existing SpeciesLists one), and fix a bug where the sort dropdown's
links set q[order_by] but the controllers only read a flat params[:by]
that the links don't send, so clicking a sort option silently did
nothing. Added ApplicationController::Queries#sort_order_from_params
for this and any similar page that forces a base filter.

Fix a missing :attach icon on SpeciesLists::Listing's Add button, to
match Projects::ListItem's.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

40 of 40 new or added lines in 7 files covered. (100.0%)

60201 of 60514 relevant lines covered (99.48%)

899.63 hits per line