MushroomObserver / mushroom-observer
99%
main: 99%

Repo Added 21 Oct 2014 06:32PM UTC

Committed 05 Jul 2026 10:40PM UTC coverage: 98.54% (+0.004%) from 98.536%

Committed by

Commit Message

Remove User.current from controller and integration tests

Extends MushroomObserver/NoUserCurrentInViews to test/controllers,
test/views, test/integration, test/system, test/mailers,
test/components, and the shared *_test_case.rb/*_extensions.rb files,
then fixes every offense the wider net turned up:

- Controller tests read the controller's own current_user (set by a
  real request dispatch) or the fixture already known to be logged in,
  instead of the thread-local global.
- Admin::SessionControllerTest's three assertions taken right after
  login (before any request dispatch) check session[:user_id] instead,
  since current_user isn't set until autologin's before_action runs.
- Capybara integration tests get a shared rack_session helper
  (CapybaraSessionExtensions) that reads the real server-side session
  hash via the rack_test driver, preserving the "did the switch
  actually happen server-side" check rather than just trusting
  rendered banner text.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

9 of 13 new or added lines in 7 files covered. (69.23%)

51503 of 52266 relevant lines covered (98.54%)

748.58 hits per line

52266 RELEVANT LINES 51503 COVERED LINES

748.58 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
28757345775	nimmo-remove-user-current-controllers-views	Remove User.current from controller and integration tests Extends MushroomObserver/NoUserCurrentInViews to test/controllers, test/views, test/integration, test/system, test/mailers, test/components, and the shared _test_case.rb/_extensions.rb f...	Pull #4688	05 Jul 2026 10:44PM UTC	nimmolo	github	98.54
28756703999	nimmo-remove-user-current-controllers-views	Merge remote-tracking branch 'origin/main' into nimmo-remove-user-current-controllers-views	Pull #4688	05 Jul 2026 10:19PM UTC	nimmolo	github	98.54
28752624031	nimmo-remove-user-current-controllers-views	Merge remote-tracking branch 'origin/main' into nimmo-remove-user-current-controllers-views	Pull #4688	05 Jul 2026 07:46PM UTC	nimmolo	github	98.48
28752114414	nimmo-remove-user-current-controllers-views	set_user_from_session only needs to set @user, not User.current Verified neither caller (autocompleters_controller, images/originals_controller) reads User.current anywhere in its request path - no version-saving, no Image creation, and the share...	Pull #4688	05 Jul 2026 07:28PM UTC	nimmolo	github	98.48
28751530117	nimmo-remove-user-current-controllers-views	Close remaining User.current reads in controllers/views; drop cop exemptions The NoUserCurrentInViews cop only covered app/controllers and app/components, and its matcher missed the ::User.current cbase-qualified form and never flagged =~/compari...	Pull #4688	05 Jul 2026 07:06PM UTC	nimmolo	github	98.48

MushroomObserver / mushroom-observer
99%
main: 99%

MushroomObserver / mushroom-observer 99% main: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on nimmo-remove-user-current-controllers-views

Recent builds

MushroomObserver / mushroom-observer
99%
main: 99%

README BADGES
x

CHANGE BRANCH
x