tarantool / luajit
93%

DEFAULT BRANCH: tarantool/master
Repo Added
Files 89
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH tarantool/master
branch: tarantool/master
CHANGE BRANCH
x

coverage: 93.065% (-0.03%) from 93.092%
19798590843

push

github

Buristan 
ARM64: Fix assembly of HREFK (again).

Thanks to Peter Cawley.

(cherry picked from commit 93ce12ee1)

When assembling the HREFK IR with the huge offset of the target node
from the table, this offset calculation and the key loading from the
node are emitted like the following:
|  ldr   x16, [x2, 40]
|  add   x16, x16, x21
|  ldr   x27, [x16, 8]
|  cmp   x27, x17

Here, `x16` is the node register, `x27` is the key register, and `x21`
is the register containing the offset.

It is possible that the register for holding the constant operand in the
addition may be chosen as the same register containing the node address,
since the full `RSET_GPR` is given to the `emit_opk()`. It will result
in the following invalid mcode:
|  ldr   x27, [x2, 40]
|  str   x27, [sp, 8]
|  add   x16, x16, x16
|  ldr   x16, [sp, 8]
|  ldr   x27, [x16, 8]
|  cmp   x27, x17

It seems that in the current implementation the LuaJIT's register
allocator always prefers the register holding the key instead, so this
does not lead to the invalid emitting. Hence, it is impossible to come
up with any valid reproducer. However, to avoid possible regressions in
the future, this patch fixes the invalid register set by excluding the
node register from it.

Sergey Kaplun:
* added the description for the problem

Part of tarantool/tarantool#11691

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>

5712 of 6046 branches covered (94.48%)

Branch coverage included in aggregate %.

21797 of 23513 relevant lines covered (92.7%)

3873185.36 hits per line

Relevant lines Covered
23513 RELEVANT LINES 21797 COVERED LINES
3873185.36 HITS PER LINE
Source Files on tarantool/master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
19798590843 tarantool/master ARM64: Fix assembly of HREFK (again). Thanks to Peter Cawley. (cherry picked from commit 93ce12ee1) When assembling the HREFK IR with the huge offset of the target node from the table, this offset calculation and ... push Buristan github
93.06
19796510573 tarantool/master macOS: Remove obsolete -single_module flag. Thanks to dundargoc. (cherry picked from commit 97813fb92) The aforementioned flag is the default since Xcode 2.2 [1]. This patch removes this flag to avoid warnings for... push Buristan github
93.09
17649971361 tarantool/master Invalidate SCEV entry when returning to lower frame. Thanks to Zhongwei Yao. (cherry picked from commit 65c849390) When returning to the lower frame, LuaJIT does not clear the Scalar Evolution analysis entry. Henc... push Buristan github
93.06
17645235243 tarantool/master ARM64: Fix LDP/STP fusion (again). Reported and analyzed by Zhongwei Yao. Fix by Peter Cawley. (cherry picked from commit b8c6ccd50) Assume we have stores/loads from the pointer with offset +488 and -16. The lower... push Buristan github
93.06
17640023329 tarantool/master x86/x64: Don't use undefined MUL/IMUL zero flag. Reported by VrIgHtEr. (cherry picked from commit c92d0cb19) When emitting the arithmetic operations on registers via the `asm_intarith()`, the next `test` instructi... push Buristan github
93.11
17634222891 tarantool/master Correctly close VM state after early OOM during open. Reported by Assumeru. (cherry picked from commit 5ca25ee83) `lua_newstate()` sets `g->str.mask` to `~(MSize)0` before calling `cpluaopen(). If OOM happens befo... push Buristan github
93.06
17618265682 tarantool/master FFI: Fix dangling CType references (again). Reported by Sergey Kaplun. (cherry picked from commit c64020f3c) This patch fixes JIT recording for the vararg calls, that was not fixed in the previous patch. The `ctr`... push Buristan github
93.07
17614139255 tarantool/master Avoid out-of-range PC for stack overflow error from snapshot restore. Reported by Sergey Kaplun. (cherry picked from commit e3fa3c48d) In case when the saved PC in the snapshot is the first (0th index) PC in the p... push Buristan github
93.07
17609805753 tarantool/master ARM64: Prevent STP fusion for conditional code emitted by TBAR. Thanks to Peter Cawley. (cherry picked from commit 7cc53f0b8) Assume we have a trace for the several `setmetatable()` calls to the same table. This t... push Buristan github
93.06
16418063871 tarantool/master test: conditionally disable flaky lj-1196 The test may lead to the assertion failure if run under Tarantool. Also, the skip condition for the Tarantool leads to stable fails for some builds on x86/x64 architecture, so they are skipped as well. Se... push Buristan github
93.06
See All Builds (1911)