tarantool / luajit / 8248340212

93%

Build Type

push

github

Committed by Buristan

Commit Message

Throw any errors before stack changes in trace stitching.

Thanks to doujiang24.

(cherry-picked from commit 3f9389edc)

The Lua stack is changed in the `recff_stitch`, so if the trace
is aborted, for example, when the `maxsnap` is reached, and an
error is thrown from there, the execution continues with an
unbalanced stack.

This patch adds a check for snapshot overflow to the
`recff_stitch` to overcome the issue for the `LJ_TRERR_SNAPOV`
case, but other cases remain unresolved and should be fixed in
other series. For a detailed description of the remaining cases,
see the issue #1166.

Maxim Kokryashkin:
* added the description and the test for the problem

Part of tarantool/tarantool#9595

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>

Run Details

5658 of 6017 branches covered (94.03%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

9 existing lines in 3 files now uncovered.

21609 of 23411 relevant lines covered (92.3%)

2814418.18 hits per line