tarantool / luajit / 6934917296

93%

Build Type

push

github

Committed by igormunkin

Commit Message

Add NaN check to IR_NEWREF.

Thanks to Peter Cawley.

(cherry-picked from commit 7f9907b4e)

When emitting IR NEWREF, there is no check for a non-NaN stored key
value. Thus, when the NaN number value is given to trace, it may be
stored as a key. This patch adds the corresponding check. If fold
optimization is enabled, this IR EQ check is dropped if it references
CONV IR from any (unsigned) integer type since NaN can be created via
conversion from an integer.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#9145

Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Igor Munkin <imun@tarantool.org>

Run Details

5375 of 5985 branches covered (0.0%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 2 files covered. (100.0%)

17 existing lines in 4 files now uncovered.

20594 of 23352 relevant lines covered (88.19%)

2754309.47 hits per line