tarantool / luajit
93%
tarantool/master: 93%

LAST BUILD BRANCH: fckxorg/fix-argv-handling
DEFAULT BRANCH: tarantool/master
Repo Added
Files 89
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fckxorg/fix-argv-handling
branch: fckxorg/fix-argv-handling
CHANGE BRANCH
x

coverage: 92.978% (+0.02%) from 92.954%
12924826641

push

github

Buristan 
Fix command-line argv handling.

(cherry-picked from commit 9ebebc9b5)

Before the patch, there was a situation where `luaL_newstate` could fail
in main and the `argv[0]` could be used as a progname in `l_message`.
However, `argv[0]` is not guaranteed to be non-NULL, so the segmentation
fault could occur. This patch fixes the issue by using the predefined
name in that case. Moreover, it refactors the `l_message`, so now there
is no need to pass `pname` everywhere.

The patch is tested with the help of the mocking of `luaL_newstate` by
providing an error-injected implementation of it and preloading it. For
preload to work, the LuaJIT must be built with dynamic build mode
enabled. The corresponding flavor is added to the CI.

The <gh-8594-sysprof-ffunc-crash.test.c> inspects internal symbols from
the LuaJIT static library, so it can't be linked for shared build. The
test is disabled for the dynamic build mode.

Since the Linux kernel 5.18-rc1 release, `argv` is forced to a single
empty string if it is empty [1], so the issue is not reproducible on new
kernels. You may inspect the `dmesg` log for the corresponding warning
entrance.

Maxim Kokryashkin:
* added the description and the test for the problem

[1]: https://lore.kernel.org/all/20220201000947.2453721-1-keescook@chromium.org/

Part of tarantool/tarantool#10709

5692 of 6031 branches covered (94.38%)

Branch coverage included in aggregate %.

7 of 10 new or added lines in 1 file covered. (70.0%)

10 existing lines in 3 files now uncovered.

21703 of 23433 relevant lines covered (92.62%)

2953451.75 hits per line

Relevant lines Covered
23433 RELEVANT LINES 21703 COVERED LINES
2953451.75 HITS PER LINE
Source Files on fckxorg/fix-argv-handling

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
12924826641 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push Buristan github
92.98
8648539856 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.61
8646804024 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.57
8639131575 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.61
8639043424 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.53
8638530688 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.6
8638378655 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.57
8638080266 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.58
7220484001 fckxorg/fix-argv-handling Fix command-line argv handling. push fckxorg github
88.6
7218957259 fckxorg/fix-argv-handling Fix command-line argv handling. push fckxorg github
88.56
See All Builds (1471)