tarantool / luajit / 13989956548

93%

Build Type

push

github

Committed by Buristan

Commit Message

ffi/gc: restore back rehashing of finalizers table

This is a follow-up to the commits
2115828bc ("FFI: Drop finalizer table
rehash after GC cycle.") and bfcbaa70e
("Drop unused function wrapper."). After them, the rehashing of the cdata
finalizer table at the end of the GC cycle is dropped. Without
reshashing of this table, the table increases the estimated amount of
memory for the GC. Hence, with the bigger `estimate`, the threshold
before starting the GC cycle is increased too. This allows allocating
more cdata objects and increasing the size of the finalizer table again.
This increases the memory estimate again and so on. As a result, we have
unlimited memory growth without rehashing of the table for the
cdata-intensive workloads.

This patch reverts back the code changes (but not the test) of the
aforementioned commits. Also, it fixes the possible crash after
rehashing of the cdata finalizers table by adding the protected call to
the GC steps on the trace itself and on the trace exit.

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>

Run Details

5707 of 6042 branches covered (94.46%)

Branch coverage included in aggregate %.

30 of 31 new or added lines in 3 files covered. (96.77%)

5 existing lines in 3 files now uncovered.

21780 of 23491 relevant lines covered (92.72%)

3843446.76 hits per line