tarantool / luajit / 7741781092

93%

push

github

Simplify handling of instable types in TNEW/TDUP load forwarding.

Thanks to Peter Cawley.

(cherry picked from commit c42c62e71)

This patch is a follow-up for the commit
b89186cb0 ("Fix handling of instable
types in TNEW/TDUP load forwarding."). The problem still occurs when
TDUP load forwarding is performed for the boolean value. The
`fwd_ahload()` always takes the type of IR without checking the type of
the TValue for this iteration.

This patch solves the issue by returning the expected type of the TValue
from the constant table (or `nil` for TNEW IR) instead. In the case of
type instability, the error in `loop_unroll()` will be raised, and the
loop will be unrolled for one more iteration to prevent inconsistencies.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#9595

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Signed-off-by: Igor Munkin <imun@tarantool.org>

5403 of 5998 branches covered (0.0%)

Branch coverage included in aggregate %.

20683 of 23371 relevant lines covered (88.5%)

2753170.17 hits per line